Make HttpClientCodec#initialBufferSize configurable, close AsyncHttpClient#1405

Author: slandelle

client/src/main/java/org/asynchttpclient/AsyncHttpClientConfig.java

@@ -241,6 +241,8 @@ public interface AsyncHttpClientConfig {
 
     int getHttpClientCodecMaxChunkSize();
 
+    int getHttpClientInitialBufferSize();
+
     boolean isDisableZeroCopy();
 
     int getHandshakeTimeout();

client/src/main/java/org/asynchttpclient/DefaultAsyncHttpClientConfig.java

@@ -116,6 +116,7 @@ public class DefaultAsyncHttpClientConfig implements AsyncHttpClientConfig {
     private final int httpClientCodecMaxInitialLineLength;
     private final int httpClientCodecMaxHeaderSize;
     private final int httpClientCodecMaxChunkSize;
+    private final int httpClientInitialBufferSize;
     private final int chunkedFileChunkSize;
     private final int webSocketMaxBufferSize;
     private final int webSocketMaxFrameSize;
@@ -197,6 +198,7 @@ private DefaultAsyncHttpClientConfig(//
             int httpClientCodecMaxInitialLineLength,//
             int httpClientCodecMaxHeaderSize,//
             int httpClientCodecMaxChunkSize,//
+            int httpClientInitialBufferSize,//
             int chunkedFileChunkSize,//
             int webSocketMaxBufferSize,//
             int webSocketMaxFrameSize,//
@@ -272,6 +274,7 @@ private DefaultAsyncHttpClientConfig(//
         this.httpClientCodecMaxInitialLineLength = httpClientCodecMaxInitialLineLength;
         this.httpClientCodecMaxHeaderSize = httpClientCodecMaxHeaderSize;
         this.httpClientCodecMaxChunkSize = httpClientCodecMaxChunkSize;
+        this.httpClientInitialBufferSize = httpClientInitialBufferSize;
         this.chunkedFileChunkSize = chunkedFileChunkSize;
         this.webSocketMaxBufferSize = webSocketMaxBufferSize;
         this.webSocketMaxFrameSize = webSocketMaxFrameSize;
@@ -540,6 +543,11 @@ public int getHttpClientCodecMaxChunkSize() {
         return httpClientCodecMaxChunkSize;
     }
 
+    @Override
+    public int getHttpClientInitialBufferSize() {
+        return httpClientInitialBufferSize;
+    }
+
     @Override
     public int getChunkedFileChunkSize() {
         return chunkedFileChunkSize;
@@ -673,6 +681,7 @@ public static class Builder {
         private int httpClientCodecMaxInitialLineLength = defaultHttpClientCodecMaxInitialLineLength();
         private int httpClientCodecMaxHeaderSize = defaultHttpClientCodecMaxHeaderSize();
         private int httpClientCodecMaxChunkSize = defaultHttpClientCodecMaxChunkSize();
+        private int httpClientInitialBufferSize = defaultHttpClientInitialBufferSize();
         private int chunkedFileChunkSize = defaultChunkedFileChunkSize();
         private int webSocketMaxBufferSize = defaultWebSocketMaxBufferSize();
         private int webSocketMaxFrameSize = defaultWebSocketMaxFrameSize();
@@ -1043,6 +1052,11 @@ public Builder setHttpClientCodecMaxChunkSize(int httpClientCodecMaxChunkSize) {
             return this;
         }
 
+        public Builder setHttpClientInitialBufferSize(int httpClientInitialBufferSize) {
+            this.httpClientInitialBufferSize = httpClientInitialBufferSize;
+            return this;
+        }
+
         public Builder setChunkedFileChunkSize(int chunkedFileChunkSize) {
             this.chunkedFileChunkSize = chunkedFileChunkSize;
             return this;
@@ -1173,6 +1187,7 @@ public DefaultAsyncHttpClientConfig build() {
                     httpClientCodecMaxInitialLineLength, //
                     httpClientCodecMaxHeaderSize, //
                     httpClientCodecMaxChunkSize, //
+                    httpClientInitialBufferSize, //
                     chunkedFileChunkSize, //
                     webSocketMaxBufferSize, //
                     webSocketMaxFrameSize, //

client/src/main/java/org/asynchttpclient/config/AsyncHttpClientConfigDefaults.java

@@ -12,7 +12,6 @@
  */
 package org.asynchttpclient.config;
 
-
 public final class AsyncHttpClientConfigDefaults {
 
     private AsyncHttpClientConfigDefaults() {
@@ -164,6 +163,10 @@ public static int defaultHttpClientCodecMaxChunkSize() {
         return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getInt(ASYNC_CLIENT_CONFIG_ROOT + "httpClientCodecMaxChunkSize");
     }
 
+    public static int defaultHttpClientInitialBufferSize() {
+        return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getInt(ASYNC_CLIENT_CONFIG_ROOT + "httpClientInitialBufferSize");
+    }
+
     public static boolean defaultDisableZeroCopy() {
         return AsyncHttpClientConfigHelper.getAsyncHttpClientConfig().getBoolean(ASYNC_CLIENT_CONFIG_ROOT + "disableZeroCopy");
     }

client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -329,7 +329,8 @@ private HttpClientCodec newHttpClientCodec() {
                 config.getHttpClientCodecMaxHeaderSize(),//
                 config.getHttpClientCodecMaxChunkSize(),//
                 false,//
-                config.isValidateResponseHeaders());
+                config.isValidateResponseHeaders(),//
+                config.getHttpClientInitialBufferSize());
     }
 
     private SslHandler createSslHandler(String peerHost, int peerPort) {

client/src/main/resources/ahc-default.properties

@@ -35,6 +35,7 @@ org.asynchttpclient.soRcvBuf=-1
 org.asynchttpclient.httpClientCodecMaxInitialLineLength=4096
 org.asynchttpclient.httpClientCodecMaxHeaderSize=8192
 org.asynchttpclient.httpClientCodecMaxChunkSize=8192
+org.asynchttpclient.httpClientInitialBufferSize=128
 org.asynchttpclient.disableZeroCopy=false
 org.asynchttpclient.handshakeTimeout=10000
 org.asynchttpclient.chunkedFileChunkSize=8192