Reduce GC overhead by call address.toString() in case of timeout only (AsyncHttpClient#1401)

Author: plokhotnyuk

client/src/main/java/org/asynchttpclient/netty/timeout/TimeoutsHolder.java

@@ -39,7 +39,7 @@ public class TimeoutsHolder {
     private volatile NettyResponseFuture<?> nettyResponseFuture;
     public final Timeout requestTimeout;
     public volatile Timeout readTimeout;
-    private volatile String remoteAddress = "not-connected";
+    private volatile InetSocketAddress remoteAddress;
 
     public TimeoutsHolder(Timer nettyTimer, NettyResponseFuture<?> nettyResponseFuture, NettyRequestSender requestSender, AsyncHttpClientConfig config) {
         this.nettyTimer = nettyTimer;
@@ -66,7 +66,7 @@ public TimeoutsHolder(Timer nettyTimer, NettyResponseFuture<?> nettyResponseFutu
     }
 
     public void initRemoteAddress(InetSocketAddress address) {
-        remoteAddress = address.toString();
+        remoteAddress = address;
     }
 
     public void startReadTimeout() {
@@ -82,8 +82,7 @@ void startReadTimeout(ReadTimeoutTimerTask task) {
                 // first call triggered from outside (else is read timeout is re-scheduling itself)
                 task = new ReadTimeoutTimerTask(nettyResponseFuture, requestSender, this, readTimeoutValue);
             }
-            Timeout readTimeout = newTimeout(task, readTimeoutValue);
-            this.readTimeout = readTimeout;
+            this.readTimeout = newTimeout(task, readTimeoutValue);
 
         } else if (task != null) {
             // read timeout couldn't re-scheduling itself, clean up
@@ -109,6 +108,6 @@ private Timeout newTimeout(TimerTask task, long delay) {
     }
 
     String remoteAddress() {
-        return remoteAddress;
+        return remoteAddress == null ?  "not-connected" : remoteAddress.toString();
     }
 }