-
Notifications
You must be signed in to change notification settings - Fork 71
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: kubernetes-sigs/structured-merge-diff
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: kubernetes-sigs/structured-merge-diff
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 6 files changed
- 4 contributors
Commits on Nov 11, 2019
-
Equality doesn't require the same amount of sophistication than ordering comparison. Implement an Equal function that does just that but does it much faster. Benchmark results show up to 96% improvement: ``` benchmark old ns/op new ns/op delta BenchmarkDeducedSimple-12 110083 103256 -6.20% BenchmarkDeducedNested-12 374366 374160 -0.06% BenchmarkDeducedNestedAcrossVersion-12 392864 405525 +3.22% BenchmarkLeafConflictAcrossVersion-12 89112 89070 -0.05% BenchmarkMultipleApplierRecursiveRealConversion-12 1564330 1574620 +0.66% BenchmarkOperations/Pod/Create-12 103693 103970 +0.27% BenchmarkOperations/Pod/Apply-12 291760 291317 -0.15% BenchmarkOperations/Pod/Update-12 193419 190470 -1.52% BenchmarkOperations/Pod/UpdateVersion-12 261692 251966 -3.72% BenchmarkOperations/Node/Create-12 152047 155710 +2.41% BenchmarkOperations/Node/Apply-12 499187 473901 -5.07% BenchmarkOperations/Node/Update-12 299271 279142 -6.73% BenchmarkOperations/Node/UpdateVersion-12 438723 403125 -8.11% BenchmarkOperations/Endpoints/Create-12 12246 11940 -2.50% BenchmarkOperations/Endpoints/Apply-12 915806 924080 +0.90% BenchmarkOperations/Endpoints/Update-12 7155675 285092 -96.02% BenchmarkOperations/Endpoints/UpdateVersion-12 14278150 544040 -96.19% BenchmarkOperations/CustomResourceDefinition/Create-12 1312734 1288472 -1.85% BenchmarkOperations/CustomResourceDefinition/Apply-12 3346591 3376864 +0.90% BenchmarkOperations/CustomResourceDefinition/Update-12 10681243 1758764 -83.53% BenchmarkOperations/CustomResourceDefinition/UpdateVersion-12 19069925 2202330 -88.45% ```
Antoine Pelisse authored and Jennifer Buckley committedNov 11, 2019 Configuration menu - View commit details
-
Copy full SHA for fa5e197 - Browse repository at this point
Copy the full SHA fa5e197View commit details -
The current Less implementation has an exponential complexity. Replacing Less with a Compare method avoids that problem.
Configuration menu - View commit details
-
Copy full SHA for 08cde4d - Browse repository at this point
Copy the full SHA 08cde4dView commit details -
Merge pull request #128 from jennybuckley/fix-1.0-compare
Cherrypick #126 to 1.0 - Implement equality for Values
Configuration menu - View commit details
-
Copy full SHA for 442c558 - Browse repository at this point
Copy the full SHA 442c558View commit details
Commits on Dec 24, 2019
-
Fix useless error message 'invalid atom'
jennybuckley authored and Antoine Pelisse committedDec 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 23465b4 - Browse repository at this point
Copy the full SHA 23465b4View commit details -
Add test for null/{} behavior of deduced types
jennybuckley authored and Antoine Pelisse committedDec 24, 2019 Configuration menu - View commit details
-
Copy full SHA for c32903d - Browse repository at this point
Copy the full SHA c32903dView commit details -
Merge pull request #140 from apelisse/fix-ugly-error-jenny
Back-port Fix from Jenny for ugly errors
Configuration menu - View commit details
-
Copy full SHA for 3d0c538 - Browse repository at this point
Copy the full SHA 3d0c538View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...release-1.0