use OptionsResolver in Milestones api

Author: fbourigault

UPGRADE.md

@@ -43,6 +43,10 @@ See [documentation](doc/customize.md) to know how to customize the client timeou
 * The `all` method now take a single argument which is an associative array of query string parameters.
 * The `getNotes` method now take only two arguments, the project id and the merge request iid.
 
+## `Gitlab\Api\Milestones` changes
+
+* The `all` method second and subsequent arguments have been replaced by a single associative array of query string parameters.
+
 ## `Gitlab\Api\Projects` changes
 
 * The `keys`, `key`, `addKey`, `removeKey`, `disableKey` and `enableKey` methods have been removed.

lib/Gitlab/Api/Milestones.php

@@ -4,16 +4,30 @@ class Milestones extends AbstractApi
 {
     /**
      * @param int $project_id
-     * @param int $page
-     * @param int $per_page
+     * @param array $parameters (
+     *
+     *     @var int[]  $iids   Return only the milestones having the given iids.
+     *     @var string $state  Return only active or closed milestones.
+     *     @var string $search Return only milestones with a title or description matching the provided string.
+     * )
+     *
      * @return mixed
      */
-    public function all($project_id, $page = 1, $per_page = self::PER_PAGE)
+    public function all($project_id, array $parameters = [])
     {
-        return $this->get($this->getProjectPath($project_id, 'milestones'), array(
-            'page' => $page,
-            'per_page' => $per_page
-        ));
+        $resolver = $this->createOptionsResolver();
+        $resolver->setDefined('iids')
+            ->setAllowedTypes('iids', 'array')
+            ->setAllowedValues('iids', function (array $value) {
+                return count($value) == count(array_filter($value, 'is_int'));
+            })
+        ;
+        $resolver->setDefined('state')
+            ->setAllowedValues('state', ['active', 'closed'])
+        ;
+        $resolver->setDefined('search');
+
+        return $this->get($this->getProjectPath($project_id, 'milestones'), $resolver->resolve($parameters));
     }
 
     /**