Skip to content

Commit 2b469d0

Browse files
avoid accessing Node specific requires when not needed
1 parent f305419 commit 2b469d0

File tree

2 files changed

+19
-9
lines changed

2 files changed

+19
-9
lines changed

packages/pg/lib/client.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
var EventEmitter = require('events').EventEmitter
44
var utils = require('./utils')
55
var sasl = require('./sasl')
6-
var pgPass = require('pgpass')
76
var TypeOverrides = require('./type-overrides')
87

98
var ConnectionParameters = require('./connection-parameters')
@@ -225,12 +224,17 @@ class Client extends EventEmitter {
225224
} else if (this.password !== null) {
226225
cb()
227226
} else {
228-
pgPass(this.connectionParameters, (pass) => {
229-
if (undefined !== pass) {
230-
this.connectionParameters.password = this.password = pass
231-
}
232-
cb()
233-
})
227+
try {
228+
const pgPass = require('pgpass')
229+
pgPass(this.connectionParameters, (pass) => {
230+
if (undefined !== pass) {
231+
this.connectionParameters.password = this.password = pass
232+
}
233+
cb()
234+
})
235+
} catch (e) {
236+
this.emit('error', e)
237+
}
234238
}
235239
}
236240

@@ -457,7 +461,7 @@ class Client extends EventEmitter {
457461
}
458462

459463
// escapeIdentifier and escapeLiteral moved to utility functions & exported
460-
// on PG
464+
// on PG
461465
// re-exported here for backwards compatibility
462466
escapeIdentifier(str) {
463467
return utils.escapeIdentifier(str)

packages/pg/lib/native/client.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
'use strict'
22

33
// eslint-disable-next-line
4-
var Native = require('pg-native')
4+
var Native
5+
try {
6+
// Wrap this `require()` in a try-catch to avoid upstream bundlers from complaining that this might not be available since it is an optional import
7+
Native = require('pg-native')
8+
} catch (e) {
9+
throw e
10+
}
511
var TypeOverrides = require('../type-overrides')
612
var EventEmitter = require('events').EventEmitter
713
var util = require('util')

0 commit comments

Comments
 (0)