|
6 | 6 | use Facebook\WebDriver\Exception\Internal\RuntimeException; |
7 | 7 | use Facebook\WebDriver\Net\URLChecker; |
8 | 8 | use Symfony\Component\Process\Process; |
9 | | -use Symfony\Component\Process\ProcessBuilder; |
10 | 9 |
|
11 | 10 | /** |
12 | 11 | * Start local WebDriver service (when remote WebDriver server is not used). |
@@ -153,35 +152,17 @@ protected function checkWasStarted($process) |
153 | 152 | } |
154 | 153 | } |
155 | 154 |
|
156 | | - /** |
157 | | - * @return Process |
158 | | - */ |
159 | | - private function createProcess() |
| 155 | + private function createProcess(): Process |
160 | 156 | { |
161 | | - // BC: ProcessBuilder deprecated since Symfony 3.4 and removed in Symfony 4.0. |
162 | | - if (class_exists(ProcessBuilder::class) |
163 | | - && mb_strpos('@deprecated', (new \ReflectionClass(ProcessBuilder::class))->getDocComment()) === false |
164 | | - ) { |
165 | | - $processBuilder = (new ProcessBuilder()) |
166 | | - ->setPrefix($this->executable) |
167 | | - ->setArguments($this->args) |
168 | | - ->addEnvironmentVariables($this->environment); |
169 | | - |
170 | | - return $processBuilder->getProcess(); |
171 | | - } |
172 | | - // Safe to use since Symfony 3.3 |
173 | 157 | $commandLine = array_merge([$this->executable], $this->args); |
174 | 158 |
|
175 | 159 | return new Process($commandLine, null, $this->environment); |
176 | 160 | } |
177 | 161 |
|
178 | 162 | /** |
179 | 163 | * Check whether given file is executable directly or using system PATH |
180 | | - * |
181 | | - * @param string $filename |
182 | | - * @return bool |
183 | 164 | */ |
184 | | - private function isExecutable($filename) |
| 165 | + private function isExecutable(string $filename): bool |
185 | 166 | { |
186 | 167 | if (is_executable($filename)) { |
187 | 168 | return true; |
|
0 commit comments