Skip to content

Commit 020407c

Browse files
committed
Refactor: Remove no longer needed compatibility layer with old Symfony
1 parent 7d7ce3d commit 020407c

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

lib/Remote/Service/DriverService.php

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Facebook\WebDriver\Exception\Internal\RuntimeException;
77
use Facebook\WebDriver\Net\URLChecker;
88
use Symfony\Component\Process\Process;
9-
use Symfony\Component\Process\ProcessBuilder;
109

1110
/**
1211
* Start local WebDriver service (when remote WebDriver server is not used).
@@ -153,35 +152,17 @@ protected function checkWasStarted($process)
153152
}
154153
}
155154

156-
/**
157-
* @return Process
158-
*/
159-
private function createProcess()
155+
private function createProcess(): Process
160156
{
161-
// BC: ProcessBuilder deprecated since Symfony 3.4 and removed in Symfony 4.0.
162-
if (class_exists(ProcessBuilder::class)
163-
&& mb_strpos('@deprecated', (new \ReflectionClass(ProcessBuilder::class))->getDocComment()) === false
164-
) {
165-
$processBuilder = (new ProcessBuilder())
166-
->setPrefix($this->executable)
167-
->setArguments($this->args)
168-
->addEnvironmentVariables($this->environment);
169-
170-
return $processBuilder->getProcess();
171-
}
172-
// Safe to use since Symfony 3.3
173157
$commandLine = array_merge([$this->executable], $this->args);
174158

175159
return new Process($commandLine, null, $this->environment);
176160
}
177161

178162
/**
179163
* Check whether given file is executable directly or using system PATH
180-
*
181-
* @param string $filename
182-
* @return bool
183164
*/
184-
private function isExecutable($filename)
165+
private function isExecutable(string $filename): bool
185166
{
186167
if (is_executable($filename)) {
187168
return true;

0 commit comments

Comments
 (0)