Add Safari workaround for detecting multi-select element

Author: oleg-andreyev

lib/WebDriverSelect.php

@@ -26,7 +26,14 @@ public function __construct(WebDriverElement $element)
         }
         $this->element = $element;
         $value = $element->getAttribute('multiple');
-        $this->isMulti = $value === 'true';
+
+        /**
+         * There is a bug in safari webdriver that returns 'multiple' instead of 'true' which does not match the spec.
+         * Apple Feedback #FB12760673
+         *
+         * @see https://www.w3.org/TR/webdriver2/#get-element-attribute
+         */
+        $this->isMulti = $value === 'true' || $value === 'multiple';
     }
 
     public function isMultiple()

tests/functional/WebDriverSelectTest.php

@@ -20,10 +20,13 @@ protected function setUp(): void
         $this->driver->get($this->getTestPageUrl(TestPage::FORM));
     }
 
-    public function testShouldCreateNewInstanceForSelectElementAndDetectIfItIsMultiple(): void
+    /**
+     * @dataProvider multipleSelectDataProvider
+     */
+    public function testShouldCreateNewInstanceForSelectElementAndDetectIfItIsMultiple(string $selector): void
     {
         $originalElement = $this->driver->findElement(WebDriverBy::cssSelector('#select'));
-        $originalMultipleElement = $this->driver->findElement(WebDriverBy::cssSelector('#select-multiple'));
+        $originalMultipleElement = $this->driver->findElement(WebDriverBy::cssSelector($selector));
 
         $select = new WebDriverSelect($originalElement);
         $selectMultiple = new WebDriverSelect($originalMultipleElement);
@@ -35,6 +38,15 @@ public function testShouldCreateNewInstanceForSelectElementAndDetectIfItIsMultip
         $this->assertTrue($selectMultiple->isMultiple());
     }
 
+    public static function multipleSelectDataProvider(): array
+    {
+        return [
+            ['#select-multiple'],
+            ['#select-multiple-2'],
+            ['#select-multiple-3'],
+        ];
+    }
+
     public function testShouldThrowExceptionWhenNotInstantiatedOnSelectElement(): void
     {
         $notSelectElement = $this->driver->findElement(WebDriverBy::cssSelector('textarea'));

tests/functional/web/form.html

@@ -48,6 +48,22 @@
             <option value="fourth">Fourth  with   spaces   inside</option>
             <option value="fifth">   Fifth surrounded by spaces    </option>
         </select>
+        <label for="select-multiple-2"></label>
+        <select name="select-multiple-2" id="select-multiple-2" multiple="multiple">
+            <option value="first">First</option>
+            <option value="second">This is second option</option>
+            <option value="third">This is not second option</option>
+            <option value="fourth">Fourth  with   spaces   inside</option>
+            <option value="fifth">   Fifth surrounded by spaces    </option>
+        </select>
+        <label for="select-multiple-3"></label>
+        <select name="select-multiple-3" id="select-multiple-3" multiple="">
+            <option value="first">First</option>
+            <option value="second">This is second option</option>
+            <option value="third">This is not second option</option>
+            <option value="fourth">Fourth  with   spaces   inside</option>
+            <option value="fifth">   Fifth surrounded by spaces    </option>
+        </select>
         <br>
 
         <fieldset>