Fixed geocoder to not cache if results are empty

Author: mikebronner

CHANGELOG.md

@@ -2,6 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [4.0.3] - 27 Oct 2017
+### Fixed
+- cache duration to work on 32-bit systems.
+- geocoder to not cache if no results are provided.
+
 ## [4.0.2] - 2 Sep 2017
 ### Fixed
 - erroneous method `getProvider()` and marked it as deprecated.

src/ProviderAndDumperAggregator.php

@@ -88,6 +88,8 @@ function () use ($query) {
             }
         );
 
+        $this->removeEmptyCacheEntry("geocoder-{$cacheKey}");
+
         return $this;
     }
 
@@ -102,6 +104,8 @@ function () use ($query) {
             }
         );
 
+        $this->removeEmptyCacheEntry("geocoder-{$cacheKey}");
+
         return $this;
     }
 
@@ -121,6 +125,8 @@ function () use ($value) {
             }
         );
 
+        $this->removeEmptyCacheEntry("geocoder-{$cacheKey}");
+
         return $this;
     }
 
@@ -135,6 +141,8 @@ function () use ($latitude, $longitude) {
             }
         );
 
+        $this->removeEmptyCacheEntry("geocoder-{$cacheKey}");
+
         return $this;
     }
 
@@ -239,4 +247,13 @@ protected function getAdapterClass(string $provider) : string
 
         return config('geocoder.adapter');
     }
+
+    protected function removeEmptyCacheEntry(string $cacheKey)
+    {
+        $result = app('cache')->get($cacheKey);
+
+        if ($result && $result->isEmpty()) {
+            app('cache')->forget($cacheKey);
+        }
+    }
 }

tests/Laravel5_5/Providers/GeocoderServiceTest.php

@@ -308,4 +308,13 @@ public function testItHandlesOnlyCityAndState()
         $this->assertEquals('Washington', $results->first()->getAdminLevels()->first()->getName());
         $this->assertEquals('United States', $results->first()->getCountry()->getName());
     }
+
+    public function testEmptyResultsAreNotCached()
+    {
+        $cacheKey = str_slug(strtolower(urlencode('_')));
+
+        Geocoder::geocode('_')->get();
+
+        $this->assertFalse(app('cache')->has("geocoder-{$cacheKey}"));
+    }
 }