Drop MiscUtils.trimStackTrace in favor of Netty's ThrowableUtil.unknownStackTrace

Author: slandelle

client/src/main/java/org/asynchttpclient/exception/ChannelClosedException.java

@@ -14,12 +14,12 @@
 
 import java.io.IOException;
 
-import static org.asynchttpclient.util.MiscUtils.trimStackTrace;
+import static io.netty.util.internal.ThrowableUtil.*;
 
 @SuppressWarnings("serial")
 public final class ChannelClosedException extends IOException {
 
-    public static final ChannelClosedException INSTANCE = trimStackTrace(new ChannelClosedException());
+    public static final ChannelClosedException INSTANCE = unknownStackTrace(new ChannelClosedException(), ChannelClosedException.class, "INSTANCE");
 
     private ChannelClosedException() {
         super("Channel closed");

client/src/main/java/org/asynchttpclient/exception/PoolAlreadyClosedException.java

@@ -12,14 +12,14 @@
  */
 package org.asynchttpclient.exception;
 
-import java.io.IOException;
+import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 
-import static org.asynchttpclient.util.MiscUtils.trimStackTrace;
+import java.io.IOException;
 
 @SuppressWarnings("serial")
 public class PoolAlreadyClosedException extends IOException {
 
-    public static final PoolAlreadyClosedException INSTANCE = trimStackTrace(new PoolAlreadyClosedException());
+    public static final PoolAlreadyClosedException INSTANCE = unknownStackTrace(new PoolAlreadyClosedException(), PoolAlreadyClosedException.class, "INSTANCE");
 
     private PoolAlreadyClosedException() {
         super("Pool is already closed");

client/src/main/java/org/asynchttpclient/exception/RemotelyClosedException.java

@@ -12,15 +12,15 @@
  */
 package org.asynchttpclient.exception;
 
-import java.io.IOException;
+import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 
-import static org.asynchttpclient.util.MiscUtils.trimStackTrace;
+import java.io.IOException;
 
 @SuppressWarnings("serial")
 public final class RemotelyClosedException extends IOException {
 
-    public static final RemotelyClosedException INSTANCE = trimStackTrace(new RemotelyClosedException());
-    
+    public static final RemotelyClosedException INSTANCE = unknownStackTrace(new RemotelyClosedException(), RemotelyClosedException.class, "INSTANCE");
+
     public RemotelyClosedException() {
         super("Remotely closed");
     }

client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java

@@ -13,7 +13,7 @@
  */
 package org.asynchttpclient.netty.channel;
 
-import static org.asynchttpclient.util.MiscUtils.trimStackTrace;
+import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 import io.netty.bootstrap.Bootstrap;
 import io.netty.buffer.ByteBufAllocator;
 import io.netty.channel.Channel;
@@ -53,16 +53,20 @@
 import javax.net.ssl.SSLEngine;
 import javax.net.ssl.SSLException;
 
-import org.asynchttpclient.*;
+import org.asynchttpclient.AsyncHandler;
+import org.asynchttpclient.AsyncHttpClientConfig;
+import org.asynchttpclient.ClientStats;
+import org.asynchttpclient.HostStats;
+import org.asynchttpclient.SslEngineFactory;
 import org.asynchttpclient.channel.ChannelPool;
 import org.asynchttpclient.channel.ChannelPoolPartitioning;
 import org.asynchttpclient.channel.NoopChannelPool;
 import org.asynchttpclient.exception.PoolAlreadyClosedException;
 import org.asynchttpclient.exception.TooManyConnectionsException;
 import org.asynchttpclient.exception.TooManyConnectionsPerHostException;
 import org.asynchttpclient.handler.AsyncHandlerExtensions;
-import org.asynchttpclient.netty.OnLastHttpContentCallback;
 import org.asynchttpclient.netty.NettyResponseFuture;
+import org.asynchttpclient.netty.OnLastHttpContentCallback;
 import org.asynchttpclient.netty.handler.AsyncHttpClientHandler;
 import org.asynchttpclient.netty.handler.HttpHandler;
 import org.asynchttpclient.netty.handler.WebSocketHandler;
@@ -129,8 +133,9 @@ public ChannelManager(final AsyncHttpClientConfig config, Timer nettyTimer) {
         }
         this.channelPool = channelPool;
 
-        tooManyConnections = trimStackTrace(new TooManyConnectionsException(config.getMaxConnections()));
-        tooManyConnectionsPerHost = trimStackTrace(new TooManyConnectionsPerHostException(config.getMaxConnectionsPerHost()));
+        
+        tooManyConnections = unknownStackTrace(new TooManyConnectionsException(config.getMaxConnections()), ChannelManager.class, "acquireChannelLock");
+        tooManyConnectionsPerHost = unknownStackTrace(new TooManyConnectionsPerHostException(config.getMaxConnectionsPerHost()), ChannelManager.class, "acquireChannelLock");
         maxTotalConnectionsEnabled = config.getMaxConnections() > 0;
         maxConnectionsPerHostEnabled = config.getMaxConnectionsPerHost() > 0;
 

client/src/main/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptor.java

@@ -14,10 +14,11 @@
 package org.asynchttpclient.netty.handler.intercept;
 
 import static io.netty.handler.codec.http.HttpHeaderNames.*;
+import static io.netty.util.internal.ThrowableUtil.unknownStackTrace;
 import static org.asynchttpclient.util.HttpConstants.Methods.GET;
 import static org.asynchttpclient.util.HttpConstants.ResponseStatusCodes.*;
 import static org.asynchttpclient.util.HttpUtils.*;
-import static org.asynchttpclient.util.MiscUtils.*;
+import static org.asynchttpclient.util.MiscUtils.isNonEmpty;
 import io.netty.channel.Channel;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponse;
@@ -50,21 +51,22 @@ public class Redirect30xInterceptor {
         REDIRECT_STATUSES.add(SEE_OTHER_303);
         REDIRECT_STATUSES.add(TEMPORARY_REDIRECT_307);
     }
-    
+
     private static final Logger LOGGER = LoggerFactory.getLogger(Redirect30xInterceptor.class);
 
     private final ChannelManager channelManager;
     private final AsyncHttpClientConfig config;
     private final NettyRequestSender requestSender;
     private final MaxRedirectException maxRedirectException;
-    
+
     public Redirect30xInterceptor(ChannelManager channelManager, AsyncHttpClientConfig config, NettyRequestSender requestSender) {
         this.channelManager = channelManager;
         this.config = config;
         this.requestSender = requestSender;
-        maxRedirectException = trimStackTrace(new MaxRedirectException("Maximum redirect reached: " + config.getMaxRedirects()));
+        maxRedirectException = unknownStackTrace(new MaxRedirectException("Maximum redirect reached: " + config.getMaxRedirects()), Redirect30xInterceptor.class,
+                "exitAfterHandlingRedirect");
     }
-    
+
     public boolean exitAfterHandlingRedirect(//
             Channel channel,//
             NettyResponseFuture<?> future,//
@@ -164,7 +166,7 @@ else if (request.getBodyGenerator() != null)
         }
         return false;
     }
-    
+
     private HttpHeaders propagatedHeaders(Request request, Realm realm, boolean keepBody) {
 
         HttpHeaders headers = request.getHeaders()//

client/src/main/java/org/asynchttpclient/util/MiscUtils.java

@@ -59,11 +59,6 @@ public static void closeSilently(Closeable closeable) {
             }
     }
 
-    public static <T extends Exception> T trimStackTrace(T e) {
-        e.setStackTrace(new StackTraceElement[] {});
-        return e;
-    }
-
     public static Throwable getCause(Throwable t) {
         Throwable cause = t.getCause();
         return cause != null ? getCause(cause) : t;