Skip to content

Commit c349eb4

Browse files
rkirovpkozlowski-opensource
authored andcommitted
fix(bundles): remove work-around rx.js module detection.
Updates rx to the newest version, because a fix is needed. Closes angular#1245
1 parent ca95846 commit c349eb4

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

gulpfile.js

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,13 @@ var bundleConfig = {
872872
paths: {
873873
"*": "dist/js/prod/es6/*.es6",
874874
"rx/*": "node_modules/rx/*.js"
875-
}
875+
},
876+
meta: {
877+
// auto-detection fails to detect properly here - https://github.com/systemjs/builder/issues/123
878+
'rx/dist/rx.all': {
879+
format: 'cjs'
880+
}
881+
}
876882
};
877883

878884
// production build
@@ -901,10 +907,13 @@ gulp.task('bundle.js.min', ['build.js.prod'], function() {
901907

902908
// development build
903909
gulp.task('bundle.js.dev', ['build.js.dev'], function() {
904-
return bundler.bundle(
905-
merge(true, bundleConfig, {
910+
var devBundleConfig = merge(true, bundleConfig);
911+
devBundleConfig.paths =
912+
merge(true, devBundleConfig.paths, {
906913
"*": "dist/js/dev/es6/*.es6"
907-
}),
914+
});
915+
return bundler.bundle(
916+
devBundleConfig,
908917
'angular2/angular2',
909918
'./dist/build/angular2.dev.js',
910919
{

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"gulp-modify": "0.0.4",
3333
"gulp-replace": "^0.5.3",
3434
"node-uuid": "1.4.x",
35-
"rx": "2.4.6",
35+
"rx": "2.5.1",
3636
"selenium-webdriver": "2.45.1",
3737
"systemjs": "^0.9.1",
3838
"traceur": "0.0.87",

tools/build/bundle.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,5 @@ module.exports.bundle = function(buildConfig, moduleName, outputFile, outputConf
1515
module.exports.modify = function(srcs, concatName) {
1616
return gulp.src(srcs)
1717
.pipe(concat(concatName))
18-
.pipe(replace('use strict', '')) // remove after https://github.com/systemjs/builder/issues/123 is fixed.
1918
.pipe(replace('sourceMappingURL', 'sourceMappingURLDisabled')) // TODO: add concat for sourceMaps
2019
}

0 commit comments

Comments
 (0)