New Handler option to fully disable the access log.

People defining their own custom logger using an OuterMiddleware will
be able to totally skip the log.go middleware, avoiding any perf
penalty.
(the previous solution was to use log.New(ioutil.Discard, "", 0))

Author: ant0ine

rest/error.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	"os"
 	"runtime/debug"
 )
 
@@ -17,6 +18,11 @@ type errorMiddleware struct {
 
 func (mw *errorMiddleware) MiddlewareFunc(h HandlerFunc) HandlerFunc {
 
+	// set the default Logger
+	if mw.Logger == nil {
+		mw.Logger = log.New(os.Stderr, "", 0)
+	}
+
 	return func(w ResponseWriter, r *Request) {
 
 		// catch user code's panic, and convert to http response

rest/handler.go

@@ -4,7 +4,6 @@ import (
 	"log"
 	"mime"
 	"net/http"
-	"os"
 	"strings"
 )
 
@@ -62,6 +61,10 @@ type ResourceHandler struct {
 	// optional, defaults to log.New(os.Stderr, "", 0)
 	Logger *log.Logger
 
+	// If true, the access log will be fully disabled.
+	// (the log middleware is not even instantiated, avoiding any performance penalty)
+	DisableLogger bool
+
 	// Custom logger used for logging the panic errors,
 	// optional, defaults to log.New(os.Stderr, "", 0)
 	ErrorLogger *log.Logger
@@ -77,14 +80,6 @@ type ResourceHandler struct {
 // if a request matches multiple Routes, the first one will be used.
 func (rh *ResourceHandler) SetRoutes(routes ...*Route) error {
 
-	// set the default Loggers
-	if rh.Logger == nil {
-		rh.Logger = log.New(os.Stderr, "", 0)
-	}
-	if rh.ErrorLogger == nil {
-		rh.ErrorLogger = log.New(os.Stderr, "", 0)
-	}
-
 	// start the router
 	rh.internalRouter = &router{
 		routes: routes,
@@ -116,13 +111,15 @@ func (rh *ResourceHandler) instantiateMiddlewares() {
 		rh.OuterMiddlewares...,
 	)
 
-	// log as the first, depend on timer and recorder.
-	middlewares = append(middlewares,
-		&logMiddleware{
-			rh.Logger,
-			rh.EnableLogAsJson,
-		},
-	)
+	// log as the first, depends on timer and recorder.
+	if !rh.DisableLogger {
+		middlewares = append(middlewares,
+			&logMiddleware{
+				rh.Logger,
+				rh.EnableLogAsJson,
+			},
+		)
+	}
 
 	if rh.EnableGzip {
 		middlewares = append(middlewares, &gzipMiddleware{})

rest/log.go

@@ -3,6 +3,7 @@ package rest
 import (
 	"encoding/json"
 	"log"
+	"os"
 	"time"
 )
 
@@ -15,6 +16,11 @@ type logMiddleware struct {
 
 func (mw *logMiddleware) MiddlewareFunc(h HandlerFunc) HandlerFunc {
 
+	// set the default Logger
+	if mw.Logger == nil {
+		mw.Logger = log.New(os.Stderr, "", 0)
+	}
+
 	return func(w ResponseWriter, r *Request) {
 
 		// call the handler