Merge branch 'api-cleanup' into wl10787-drop-cleanup

# Conflicts:
#	devapi/session.cc
#	devapi/table_crud.cc
#	devapi/tests/crud-t.cc
#	include/mysql_devapi.h
#	xapi/tests/test.h

Author: rsomla1

CMakeLists.txt

@@ -204,15 +204,14 @@ else()
   add_definitions(-DCONCPP_BUILD_SHARED)
   set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
+  # Hide all symbols that are not explicitly exported.
   # Note: setting target property CXX_VISIBILITY did not work for
   # object libraries that we use to build the connector.
 
-  if(CMAKE_COMPILER_IS_GNUCXX)
-    if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-      add_compile_options(-fvisibility-ms-compat)
-    elseif()
-      add_compile_options(-fvisibility=hidden)
-    endif()
+  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    add_compile_options(-fvisibility-ms-compat)
+  elseif(CMAKE_COMPILER_IS_GNUCXX)
+    add_compile_options(-fvisibility=hidden)
   endif()
 
 endif()
@@ -518,6 +517,8 @@ SET_INTERFACE_OPTIONS(try devapi)
 # TODO: Do it also for the shared library
 #
 
+if(NOT WIN32)
+
 find_program(LDD ldd)
 if(NOT LDD)
   find_program(LDD otool)
@@ -533,6 +534,8 @@ if(LDD)
   )
 endif()
 
+endif()
+
 #
 # Linking test
 #
@@ -591,11 +594,11 @@ if(NOT CMAKE_INSTALL_PREFIX)
     else()
       set(install_prefix "C:/Program Files (x86)")
     endif()
-    set(CMAKE_INSTALL_PREFIX "${install_prefix}/MySQL/MySQL Connector C++ 2.0")
+    set(CMAKE_INSTALL_PREFIX "${install_prefix}/MySQL/MySQL Connector C++ ${CONCPP_PACKAGE_BASE_VERSION}")
 
   else()
 
-    set(CMAKE_INSTALL_PREFIX "/usr/local/mysql/connector-c++-2.0")
+    set(CMAKE_INSTALL_PREFIX "/usr/local/mysql/connector-c++-${CONCPP_PACKAGE_BASE_VERSION}")
 
   endif()
 

README.txt

@@ -1,4 +1,4 @@
-MySQL Connector/C++ 2.0
+MySQL Connector/C++ 8.0
 
 This is a release of MySQL Connector/C++, Oracle's
 dual-license C++ API for connecting client applications
@@ -46,6 +46,9 @@ DOCUMENTATION LOCATION
 You can find the documentation on the MySQL website at
 <http://dev.mysql.com/doc/dev/connector-cpp/>
 
+For the new features/bugfix history, see release notes at
+<https://dev.mysql.com/doc/relnotes/connector-cpp/en/news-8-0-5.html>.
+Note that the initial releases used major version 2.0.
 
 CONTACT
 =======

cdk/cmake/headers.cmake

@@ -59,6 +59,29 @@ SET(headers_dir "${headers_dir}/headers")
 #MESSAGE("headers.cmake: ${headers_dir}")
 
 
+#
+# Check if given list of headers includes all headers that can be found in
+# the current directory.
+#
+
+function(check_headers)
+
+  file(GLOB all_headers RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "*.h")
+
+  foreach(header IN LISTS ARGV)
+    #message("- checking header: ${header}\n")
+    list(REMOVE_ITEM all_headers ${header})
+  endforeach()
+
+  list(LENGTH all_headers remains)
+
+  if(remains GREATER 0)
+    message(WARNING "Extra headers found in ${CMAKE_CURRENT_SOURCE_DIR}: ${all_headers}")
+  endif()
+
+endfunction()
+
+
 #
 # Set-up header declarations with given folder as a base location for all
 # public headers.