Merge branch 'api-cleanup' into wl10980-row-locking

# Conflicts:
#	devapi/tests/crud-t.cc
#	include/devapi/collection_crud.h
#	include/devapi/statement.h
#	xapi/tests/xapi_crud-t.cc

Author: rsomla1

CMakeLists.txt

@@ -204,15 +204,14 @@ else()
   add_definitions(-DCONCPP_BUILD_SHARED)
   set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 
+  # Hide all symbols that are not explicitly exported.
   # Note: setting target property CXX_VISIBILITY did not work for
   # object libraries that we use to build the connector.
 
-  if(CMAKE_COMPILER_IS_GNUCXX)
-    if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-      add_compile_options(-fvisibility-ms-compat)
-    elseif()
-      add_compile_options(-fvisibility=hidden)
-    endif()
+  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+    add_compile_options(-fvisibility-ms-compat)
+  elseif(CMAKE_COMPILER_IS_GNUCXX)
+    add_compile_options(-fvisibility=hidden)
   endif()
 
 endif()

cdk/cmake/headers.cmake

@@ -59,6 +59,29 @@ SET(headers_dir "${headers_dir}/headers")
 #MESSAGE("headers.cmake: ${headers_dir}")
 
 
+#
+# Check if given list of headers includes all headers that can be found in
+# the current directory.
+#
+
+function(check_headers)
+
+  file(GLOB all_headers RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "*.h")
+
+  foreach(header IN LISTS ARGV)
+    #message("- checking header: ${header}\n")
+    list(REMOVE_ITEM all_headers ${header})
+  endforeach()
+
+  list(LENGTH all_headers remains)
+
+  if(remains GREATER 0)
+    message(WARNING "Extra headers found in ${CMAKE_CURRENT_SOURCE_DIR}: ${all_headers}")
+  endif()
+
+endfunction()
+
+
 #
 # Set-up header declarations with given folder as a base location for all
 # public headers.

cdk/include/mysql/cdk/api/document.h

@@ -170,7 +170,7 @@ class Doc_base : public Expr_base< Doc_processor<PRC> >
   with Doc_path_processor to describe one element of the path.
 */
 
-class Doc_path_processor
+class Doc_path_element_processor
 {
 public:
 
@@ -198,7 +198,20 @@ class Doc_path_processor
   virtual void any_path() =0;
 };
 
-typedef Expr_list< Expr_base<Doc_path_processor> > Doc_path;
+
+class Doc_path_processor
+  : public List_processor< Doc_path_element_processor >
+{
+public:
+
+  typedef Element_prc::string  string;
+  typedef Element_prc::index_t index_t;
+
+  // The "$" path which denotes the whole document.
+  virtual void whole_document() = 0;
+};
+
+typedef Expr_base<Doc_path_processor>  Doc_path;
 
 
 }}  // cdk::api
@@ -209,7 +222,7 @@ namespace cdk {
 class Doc_path_storage
   : public api::Doc_path
   , public api::Doc_path::Processor
-  , api::Doc_path_processor
+  , api::Doc_path_element_processor
 {
 public:
 
@@ -221,6 +234,9 @@ class Doc_path_storage
     DOUBLE_ASTERISK
   };
 
+  using api::Doc_path_element_processor::string;
+  using api::Doc_path_element_processor::index_t;
+
 protected:
 
   struct Path_el
@@ -243,7 +259,12 @@ class Doc_path_storage
 
   bool is_empty() const
   {
-    return 0 == length();
+    return m_whole_document ? false : 0 == length();
+  }
+
+  bool is_whole_document() const
+  {
+    return m_whole_document;
   }
 
   const Path_el& get_el(size_t pos) const
@@ -260,11 +281,17 @@ class Doc_path_storage
 
   void process(Processor &prc) const
   {
+    if (m_whole_document)
+    {
+      prc.whole_document();
+      return;
+    }
+
     prc.list_begin();
 
     for (size_t pos = 0; pos < m_path.size(); ++pos)
     {
-      api::Doc_path_processor *eprc = prc.list_el();
+      api::Doc_path_element_processor *eprc = prc.list_el();
       if (eprc)
       {
         const Path_el &el = m_path[pos];
@@ -285,10 +312,12 @@ class Doc_path_storage
 
   // List_processor
 
-  Path_el *m_el;
+  bool  m_whole_document = false;
+  Path_el *m_el = NULL;
 
   Element_prc* list_el()
   {
+    assert(!m_whole_document);
     m_path.push_back(Path_el());
     m_el = &m_path.back();
     return this;
@@ -298,6 +327,11 @@ class Doc_path_storage
 
   // Doc_path_processor
 
+  void whole_document()
+  {
+    m_whole_document = true;
+  }
+
   void member(const string &name)
   {
     assert(m_el);
@@ -398,10 +432,10 @@ struct Safe_prc< cdk::api::Doc_processor<PRC> >
 
 
 template<>
-struct Safe_prc<api::Doc_path_processor>
-  : Safe_prc_base<api::Doc_path_processor>
+struct Safe_prc<api::Doc_path_element_processor>
+  : Safe_prc_base<api::Doc_path_element_processor>
 {
-  typedef Safe_prc_base<api::Doc_path_processor> Base;
+  typedef Safe_prc_base<api::Doc_path_element_processor> Base;
   using Base::Processor;
   typedef Processor::string  string;
   typedef Processor::index_t index_t;
@@ -430,6 +464,42 @@ struct Safe_prc<api::Doc_path_processor>
   { return m_prc ? m_prc->any_path() : (void)NULL; }
 };
 
+template<>
+struct Safe_prc<api::Doc_path_processor>
+  : Safe_prc_base<api::Doc_path_processor>
+{
+
+  typedef Safe_prc_base<api::Doc_path_processor> Base;
+  using Base::Processor;
+  typedef Processor::string  string;
+  typedef Processor::index_t index_t;
+
+  Safe_prc(Processor *prc) : Base(prc)
+  {}
+
+  Safe_prc(Processor &prc) : Base(&prc)
+  {}
+
+  void list_begin()
+  {
+    if (m_prc)
+      m_prc->list_begin();
+  }
+
+  void list_end()
+  {
+    if (m_prc)
+      m_prc->list_end();
+  }
+
+  api::Doc_path_processor::Element_prc* list_el()
+  { return m_prc ? m_prc->list_el() : NULL; }
+
+  void whole_document()
+  { return m_prc ? m_prc->whole_document() : (void)NULL; }
+
+};
+
 }
 
 #endif

cdk/include/mysql/cdk/protocol/mysqlx/expr.h

@@ -235,11 +235,14 @@ class Doc_path
     MEMBER_ASTERISK = 2,
     ARRAY_INDEX = 3,
     ARRAY_INDEX_ASTERISK = 4,
-    DOUBLE_ASTERISK = 5
+    DOUBLE_ASTERISK = 5,
   };
 
   virtual ~Doc_path() {}
 
+  // The "$" path which denotes the whole document.
+  virtual bool is_whole_document() const = 0;
+
   virtual unsigned length() const =0;
   virtual Type     get_type(unsigned pos) const =0;
   virtual const string* get_name(unsigned pos) const =0;

cdk/mysqlx/converters.h

@@ -170,6 +170,11 @@ struct Doc_path_storage
 
   // Proto_path interface
 
+  bool is_whole_document() const
+  {
+    return cdk::Doc_path_storage::is_whole_document();
+  }
+
   unsigned length() const
   {
     size_t len = cdk::Doc_path_storage::length();