clean up static Exceptions

Author: slandelle

src/main/java/com/ning/http/client/MaxRedirectException.java

@@ -23,18 +23,9 @@ public class MaxRedirectException extends Exception {
     private static final long serialVersionUID = 1L;
 
     public MaxRedirectException() {
-        super();
     }
 
     public MaxRedirectException(String msg) {
-        super(msg);
+        super(msg, null, true, false);
     }
-
-    public MaxRedirectException(Throwable cause) {
-        super(cause);
-    }
-
-    public MaxRedirectException(String message, Throwable cause) {
-        super(message, cause);
-    }
-}
+}

src/main/java/com/ning/http/client/providers/netty/channel/ChannelManager.java

@@ -16,7 +16,7 @@
 import static com.ning.http.client.providers.netty.util.HttpUtils.WEBSOCKET;
 import static com.ning.http.client.providers.netty.util.HttpUtils.isSecure;
 import static com.ning.http.client.providers.netty.util.HttpUtils.isWebSocket;
-import static com.ning.http.util.MiscUtils.buildStaticException;
+import static com.ning.http.util.MiscUtils.buildStaticIOException;
 import static org.jboss.netty.channel.Channels.pipeline;
 import static org.jboss.netty.handler.ssl.SslHandler.getDefaultBufferPool;
 
@@ -123,9 +123,9 @@ public ChannelManager(AsyncHttpClientConfig config, NettyAsyncHttpProviderConfig
         }
         this.channelPool = channelPool;
 
-        tooManyConnections = buildStaticException(String.format("Too many connections %s", config.getMaxConnections()));
-        tooManyConnectionsPerHost = buildStaticException(String.format("Too many connections per host %s", config.getMaxConnectionsPerHost()));
-        poolAlreadyClosed = buildStaticException("Pool is already closed");
+        tooManyConnections = buildStaticIOException(String.format("Too many connections %s", config.getMaxConnections()));
+        tooManyConnectionsPerHost = buildStaticIOException(String.format("Too many connections per host %s", config.getMaxConnectionsPerHost()));
+        poolAlreadyClosed = buildStaticIOException("Pool is already closed");
         maxTotalConnectionsEnabled = config.getMaxConnections() > 0;
         maxConnectionsPerHostEnabled = config.getMaxConnectionsPerHost() > 0;
 

src/main/java/com/ning/http/client/providers/netty/handler/Processor.java

@@ -13,6 +13,8 @@
  */
 package com.ning.http.client.providers.netty.handler;
 
+import static com.ning.http.util.MiscUtils.buildStaticIOException;
+
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelHandlerContext;
 import org.jboss.netty.channel.ChannelStateEvent;
@@ -40,10 +42,7 @@ public class Processor extends SimpleChannelUpstreamHandler {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(Processor.class);
 
-    public static final IOException CHANNEL_CLOSED_EXCEPTION = new IOException("Channel closed");
-    static {
-        CHANNEL_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[0]);
-    }
+    public static final IOException CHANNEL_CLOSED_EXCEPTION = buildStaticIOException("Channel closed");
 
     private final AsyncHttpClientConfig config;
     private final ChannelManager channelManager;

src/main/java/com/ning/http/client/providers/netty/handler/Protocol.java

@@ -81,7 +81,6 @@ public Protocol(ChannelManager channelManager, AsyncHttpClientConfig config, Net
         hasResponseFilters = !config.getResponseFilters().isEmpty();
         hasIOExceptionFilters = !config.getIOExceptionFilters().isEmpty();
         maxRedirectException = new MaxRedirectException("Maximum redirect reached: " + config.getMaxRedirects());
-        maxRedirectException.setStackTrace(new StackTraceElement[] {});
     }
 
     public abstract void handle(Channel channel, NettyResponseFuture<?> future, Object message) throws Exception;

src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java

@@ -12,7 +12,7 @@
  */
 package com.ning.http.util;
 
-import static com.ning.http.util.MiscUtils.isNonEmpty;
+import static com.ning.http.util.MiscUtils.*;
 import static java.nio.charset.StandardCharsets.ISO_8859_1;
 
 import com.ning.http.client.AsyncHttpClientConfig;
@@ -37,11 +37,7 @@
  */
 public class AsyncHttpProviderUtils {
 
-    public static final IOException REMOTELY_CLOSED_EXCEPTION = new IOException("Remotely closed");
-
-    static {
-        REMOTELY_CLOSED_EXCEPTION.setStackTrace(new StackTraceElement[] {});
-    }
+    public static final IOException REMOTELY_CLOSED_EXCEPTION = buildStaticIOException("Remotely closed");
 
     public final static Charset DEFAULT_CHARSET = ISO_8859_1;
 

src/main/java/com/ning/http/util/MiscUtils.java

@@ -58,7 +58,7 @@ public static void closeSilently(Closeable closeable) {
         }
     }
 
-    public static IOException buildStaticException(String message) {
+    public static IOException buildStaticIOException(String message) {
         IOException ioe = new IOException(message);
         ioe.setStackTrace(new StackTraceElement[] {});
         return ioe;