Skip to content

Commit 3dae468

Browse files
committed
Merge branch 'dojo-fix-non-keyed-version-update' of https://github.com/agubler/js-framework-benchmark into agubler-dojo-fix-non-keyed-version-update
2 parents d22a270 + d2ea388 commit 3dae468

File tree

5 files changed

+20
-16
lines changed

5 files changed

+20
-16
lines changed

frameworks/keyed/dojo/package.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,19 @@
44
"js-framework-benchmark": {
55
"frameworkVersionFromPackage": "@dojo/framework",
66
"customURL": "/output/dist",
7-
"issues": [694]
7+
"issues": [
8+
694
9+
]
810
},
911
"scripts": {
1012
"build-prod": "./node_modules/.bin/dojo build"
1113
},
1214
"dependencies": {
13-
"@dojo/framework": "^6.0.0"
15+
"@dojo/framework": "^7.0.0"
1416
},
1517
"devDependencies": {
16-
"@dojo/cli": "^6.0.0",
17-
"@dojo/cli-build-app": "^6.0.0",
18+
"@dojo/cli": "^7.0.0",
19+
"@dojo/cli-build-app": "^7.0.0",
1820
"typescript": "3.5.2"
1921
}
2022
}

frameworks/keyed/dojo/src/Buttons.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { create, w, v } from '@dojo/framework/core/vdom'
1+
import { create, w, v, diffProperty } from '@dojo/framework/core/vdom'
22
import Button from './Button';
33

44
export interface ButtonConfig {
@@ -11,14 +11,15 @@ export interface ButtonsProperties {
1111
buttonConfigs: ButtonConfig[];
1212
}
1313

14-
const factory = create().properties<ButtonsProperties>();
14+
const factory = create({ diffProperty }).properties<ButtonsProperties>();
1515

16-
export default factory(function Buttons({ properties }) {
16+
export default factory(function Buttons({ properties, middleware: { diffProperty } }) {
17+
diffProperty('buttonConfigs', properties, () => {});
1718
const { buttonConfigs } = properties();
1819
return v('div', { classes: [ 'jumbotron' ] }, [
1920
v('div', { classes: [ 'row' ] }, [
2021
v('div', { classes: [ 'col-md-6' ] }, [
21-
v('h1', ['Dojo v6.0.0'])
22+
v('h1', ['Dojo v7'])
2223
]),
2324
v('div', { classes: [ 'col-md-6' ] }, buttonConfigs.map(({ id, label, onClick }) => {
2425
return w(Button, { key: id, id, label, onClick });

frameworks/non-keyed/dojo/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99
"build-prod": "./node_modules/.bin/dojo build"
1010
},
1111
"dependencies": {
12-
"@dojo/framework": "^6.0.0"
12+
"@dojo/framework": "^7.0.0"
1313
},
1414
"devDependencies": {
15-
"@dojo/cli": "^6.0.0",
16-
"@dojo/cli-build-app": "^6.0.0",
15+
"@dojo/cli": "^7.0.0",
16+
"@dojo/cli-build-app": "^7.0.0",
1717
"typescript": "3.5.2"
1818
}
1919
}

frameworks/non-keyed/dojo/src/App.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default factory(function App({ middleware: { store }}) {
2222
return null;
2323
}
2424
return w(Row, {
25-
key,
25+
key: item.id,
2626
id: item.id,
2727
label: item.label,
2828
onSelect: store.select

frameworks/non-keyed/dojo/src/Buttons.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { create, w, v } from '@dojo/framework/core/vdom'
1+
import { create, w, v, diffProperty } from '@dojo/framework/core/vdom'
22
import Button from './Button';
33

44
export interface ButtonConfig {
@@ -11,14 +11,15 @@ export interface ButtonsProperties {
1111
buttonConfigs: ButtonConfig[];
1212
}
1313

14-
const factory = create().properties<ButtonsProperties>();
14+
const factory = create({ diffProperty }).properties<ButtonsProperties>();
1515

16-
export default factory(function Buttons({ properties }) {
16+
export default factory(function Buttons({ properties, middleware: { diffProperty } }) {
17+
diffProperty('buttonConfigs', properties, () =>{});
1718
const { buttonConfigs } = properties();
1819
return v('div', { classes: [ 'jumbotron' ] }, [
1920
v('div', { classes: [ 'row' ] }, [
2021
v('div', { classes: [ 'col-md-6' ] }, [
21-
v('h1', ['Dojo v6.0.0'])
22+
v('h1', ['Dojo v7'])
2223
]),
2324
v('div', { classes: [ 'col-md-6' ] }, buttonConfigs.map(({ id, label, onClick }) => {
2425
return w(Button, { key: id, id, label, onClick });

0 commit comments

Comments
 (0)