Skip to content

Commit dba42bf

Browse files
riceamibrunin
authored andcommitted
[Backport] Security bug 1148309
Manual backport of patch originally reviewed on https://chromium-review.googlesource.com/c/chromium/src/+/2562905: Update the restricted port list Add ports 69, 137, 161, 554, 1719, 1720, 1723, 6566 to the restricted ports list to match Firefox. See https://hg.mozilla.org/mozilla-central/file/tip/netwerk/base/nsIOService.cpp. Leave out port 10080 for now as it seems likely to cause compatibility problems. BUG=1148309 Change-Id: I16f9a61068dbe35334fd5ca2bf55b3ab0287df74 Reviewed-by: David Schinazi <[email protected]> Commit-Queue: Adam Rice <[email protected]> Cr-Commit-Position: refs/heads/master@{#832169} Reviewed-by: Allan Sandfeld Jensen <[email protected]>
1 parent eb908d2 commit dba42bf

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

chromium/net/base/port_util.cc

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const int kRestrictedPorts[] = {
3737
42, // name
3838
43, // nicname
3939
53, // domain
40+
69, // tftp
4041
77, // priv-rjs
4142
79, // finger
4243
87, // ttylink
@@ -54,8 +55,10 @@ const int kRestrictedPorts[] = {
5455
119, // nntp
5556
123, // NTP
5657
135, // loc-srv /epmap
58+
137, // netbios
5759
139, // netbios
5860
143, // imap2
61+
161, // snmp
5962
179, // BGP
6063
389, // ldap
6164
427, // SLP (Also used by Apple Filing Protocol)
@@ -70,19 +73,24 @@ const int kRestrictedPorts[] = {
7073
532, // netnews
7174
540, // uucp
7275
548, // AFP (Apple Filing Protocol)
76+
554, // rtsp
7377
556, // remotefs
7478
563, // nntp+ssl
7579
587, // stmp?
7680
601, // ??
7781
636, // ldap+ssl
7882
993, // ldap+ssl
7983
995, // pop3+ssl
84+
1719, // h323gatestat
85+
1720, // h323hostcall
86+
1723, // pptp
8087
2049, // nfs
8188
3659, // apple-sasl / PasswordServer
8289
4045, // lockd
83-
5060, // sip
84-
5061, // sips
90+
5060, // sip
91+
5061, // sips
8592
6000, // X11
93+
6566, // sane-port
8694
6665, // Alternate IRC [Apple addition]
8795
6666, // Alternate IRC [Apple addition]
8896
6667, // Standard IRC [Apple addition]

0 commit comments

Comments
 (0)