Skip to content

Commit 7b9e308

Browse files
Ying WangGerrit Code Review
authored andcommitted
Merge ""debug" in those modules is discouraged"
2 parents e9fc6c1 + 75ac6f2 commit 7b9e308

File tree

11 files changed

+4
-54
lines changed

11 files changed

+4
-54
lines changed

tools/elftree/Android.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ ifdef cur_platform
2929
#LOCAL_SHARED_LIBRARIES := $(shared_libraries)
3030
#LOCAL_STATIC_LIBRARIES := $(static_libraries)
3131
#LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)
32-
#LOCAL_MODULE_TAGS := debug
3332
#LOCAL_LDLIBS +=
3433
#include $(BUILD_EXECUTABLE)
3534

tools/emulator/opengl/common.mk

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ _emugl_HOST_modules :=
3131
emugl-begin-module = \
3232
$(eval include $(CLEAR_VARS)) \
3333
$(eval LOCAL_MODULE := $1) \
34-
$(eval LOCAL_MODULE_TAGS := debug) \
3534
$(eval LOCAL_MODULE_CLASS := $(patsubst HOST_%,%,$(patsubst %EXECUTABLE,%EXECUTABLES,$(patsubst %LIBRARY,%LIBRARIES,$2)))) \
3635
$(eval LOCAL_IS_HOST_MODULE := $(if $3,true,))\
3736
$(eval LOCAL_C_INCLUDES := $(EMUGL_COMMON_INCLUDES)) \
@@ -239,4 +238,3 @@ emugl-set-shared-library-subpath = \
239238
$(eval LOCAL_UNSTRIPPED_PATH := $(TARGET_OUT_SHARED_LIBRARIES_UNSTRIPPED)/$1)\
240239
$(eval _emugl.$(LOCAL_MODULE).moved := true)\
241240
$(call emugl-export-outer,ADDITIONAL_DEPENDENCIES,$(LOCAL_MODULE_PATH)/$(LOCAL_MODULE)$(TARGET_SHLIB_SUFFIX))
242-

tools/emulator/opengl/system/egl/Android.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ LOCAL_MODULE := egl.cfg
3333
LOCAL_SRC_FILES := $(LOCAL_MODULE)
3434

3535
LOCAL_MODULE_PATH := $(TARGET_OUT)/lib/egl
36-
LOCAL_MODULE_TAGS := debug
3736
LOCAL_MODULE_CLASS := ETC
3837

3938
include $(BUILD_PREBUILT)

tools/emulator/opengl/tests/gles_android_wrapper/Android.mk

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ LOCAL_MODULE := egl.cfg
5656
LOCAL_SRC_FILES := $(LOCAL_MODULE)
5757

5858
LOCAL_MODULE_PATH := $(TARGET_OUT)/lib/egl
59-
LOCAL_MODULE_TAGS := debug
6059
LOCAL_MODULE_CLASS := ETC
6160

6261
include $(BUILD_PREBUILT)
@@ -70,11 +69,6 @@ LOCAL_MODULE := gles_emul.cfg
7069
LOCAL_SRC_FILES := $(LOCAL_MODULE)
7170

7271
LOCAL_MODULE_PATH := $(TARGET_OUT)/etc
73-
LOCAL_MODULE_TAGS := debug
7472
LOCAL_MODULE_CLASS := ETC
7573

7674
include $(BUILD_PREBUILT)
77-
78-
79-
80-

tools/emulator/system/camera/Android.mk

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
ifndef BUILD_EMULATOR_CAMERA_HAL
16-
BUILD_EMULATOR_CAMERA_HAL := true
1715

1816
LOCAL_PATH := $(call my-dir)
1917

@@ -71,7 +69,4 @@ else
7169
LOCAL_MODULE := camera.goldfish
7270
endif
7371

74-
LOCAL_MODULE_TAGS := debug
7572
include $(BUILD_SHARED_LIBRARY)
76-
77-
endif # BUILD_EMULATOR_CAMERA_HAL

tools/emulator/system/gps/Android.mk

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
# development.git/tools/emulator/. The following test is to ensure
1818
# smooth builds even if the tree contains both versions.
1919
#
20-
ifndef BUILD_EMULATOR_GPS_MODULE
21-
BUILD_EMULATOR_GPS_MODULE := true
2220

2321
LOCAL_PATH := $(call my-dir)
2422

@@ -35,7 +33,4 @@ LOCAL_MODULE := gps.vbox_x86
3533
else
3634
LOCAL_MODULE := gps.goldfish
3735
endif
38-
LOCAL_MODULE_TAGS := debug
3936
include $(BUILD_SHARED_LIBRARY)
40-
41-
endif # BUILD_EMULATOR_GPS_MODULE

tools/emulator/system/libqemu/tests.mk

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,25 @@
66
include $(CLEAR_VARS)
77
LOCAL_MODULE := test-libqemu-1
88
LOCAL_SRC_FILES := test_host_1.c
9-
LOCAL_MODULE_TAGS := debug
9+
LOCAL_MODULE_TAGS := tests
1010
include $(BUILD_HOST_EXECUTABLE)
1111

1212
include $(CLEAR_VARS)
1313
LOCAL_MODULE := test-libqemu-2
1414
LOCAL_SRC_FILES := test_host_2.c
15-
LOCAL_MODULE_TAGS := debug
15+
LOCAL_MODULE_TAGS := tests
1616
include $(BUILD_HOST_EXECUTABLE)
1717

1818
include $(CLEAR_VARS)
1919
LOCAL_MODULE := test-libqemu-1
2020
LOCAL_SRC_FILES := test_guest_1.c test_util.c
21-
LOCAL_MODULE_TAGS := debug
21+
LOCAL_MODULE_TAGS := tests
2222
LOCAL_STATIC_LIBRARIES := libcutils
2323
include $(BUILD_EXECUTABLE)
2424

2525
include $(CLEAR_VARS)
2626
LOCAL_MODULE := test-libqemu-2
2727
LOCAL_SRC_FILES := test_guest_2.c test_util.c
28-
LOCAL_MODULE_TAGS := debug
28+
LOCAL_MODULE_TAGS := tests
2929
LOCAL_STATIC_LIBRARIES := libcutils
3030
include $(BUILD_EXECUTABLE)

tools/emulator/system/lights/Android.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,5 @@ LOCAL_MODULE_PATH := $(TARGET_OUT_SHARED_LIBRARIES)/hw
2222
LOCAL_SHARED_LIBRARIES := liblog libcutils
2323
LOCAL_SRC_FILES := lights_qemu.c
2424
LOCAL_MODULE := lights.goldfish
25-
LOCAL_MODULE_TAGS := debug
2625
LOCAL_CFLAGS += -DLIGHT_BACKLIGHT
2726
include $(BUILD_SHARED_LIBRARY)

tools/emulator/system/qemu-props/Android.mk

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,6 @@
1616
# that should only run in the emulator.
1717
#
1818

19-
# We're moving the emulator-specific platform libs to
20-
# development.git/tools/emulator/. The following test is to ensure
21-
# smooth builds even if the tree contains both versions.
22-
#
23-
ifndef BUILD_EMULATOR_QEMU_PROPS
24-
BUILD_EMULATOR_QEMU_PROPS := true
25-
2619
LOCAL_PATH := $(call my-dir)
2720

2821
# The 'qemu-props' program is run from /system/etc/init.goldfish.rc
@@ -32,9 +25,4 @@ include $(CLEAR_VARS)
3225
LOCAL_MODULE := qemu-props
3326
LOCAL_SRC_FILES := qemu-props.c
3427
LOCAL_SHARED_LIBRARIES := libcutils
35-
# we don't want this in 'user' builds which don't have
36-
# emulator-specific binaries.
37-
LOCAL_MODULE_TAGS := debug
3828
include $(BUILD_EXECUTABLE)
39-
40-
endif # BUILD_EMULATOR_QEMU_PROPS

tools/emulator/system/qemud/Android.mk

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
# development.git/tools/emulator/. The following test is to ensure
55
# smooth builds even if the tree contains both versions.
66
#
7-
ifndef BUILD_EMULATOR_QEMUD
8-
BUILD_EMULATOR_QEMUD := true
97

108
LOCAL_PATH:= $(call my-dir)
119
include $(CLEAR_VARS)
@@ -18,8 +16,5 @@ LOCAL_SHARED_LIBRARIES := \
1816
libcutils \
1917

2018
LOCAL_MODULE:= qemud
21-
LOCAL_MODULE_TAGS := debug
2219

2320
include $(BUILD_EXECUTABLE)
24-
25-
endif # BUILD_EMULATOR_QEMUD

tools/emulator/system/sensors/Android.mk

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,8 @@
1313
# limitations under the License.
1414

1515

16-
# We're moving the emulator-specific platform libs to
17-
# development.git/tools/emulator/. The following test is to ensure
18-
# smooth builds even if the tree contains both versions.
19-
#
20-
ifndef BUILD_EMULATOR_SENSORS_MODULE
21-
BUILD_EMULATOR_SENSORS_MODULE := true
22-
2316
LOCAL_PATH := $(call my-dir)
2417

25-
ifneq ($(TARGET_PRODUCT),sim)
2618
# HAL module implemenation stored in
2719
# hw/<SENSORS_HARDWARE_MODULE_ID>.<ro.hardware>.so
2820
include $(CLEAR_VARS)
@@ -35,8 +27,4 @@ LOCAL_MODULE := sensors.vbox_x86
3527
else
3628
LOCAL_MODULE := sensors.goldfish
3729
endif
38-
LOCAL_MODULE_TAGS := debug
3930
include $(BUILD_SHARED_LIBRARY)
40-
endif
41-
42-
endif # BUILD_EMULATOR_SENSORS_MODULE

0 commit comments

Comments
 (0)