Skip to content

Commit 11754ff

Browse files
committed
Clean code
1 parent b536d19 commit 11754ff

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

library/src/com/nostra13/universalimageloader/core/LoadAndDisplayImageTask.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import android.graphics.Bitmap;
1919
import android.os.Handler;
20+
2021
import com.nostra13.universalimageloader.cache.disc.DiscCacheAware;
2122
import com.nostra13.universalimageloader.core.assist.FailReason;
2223
import com.nostra13.universalimageloader.core.assist.FailReason.FailType;
@@ -228,7 +229,7 @@ private Bitmap tryLoadBitmap() throws TaskCancelledException {
228229
loadedFrom = LoadedFrom.DISC_CACHE;
229230

230231
checkTaskNotActual();
231-
bitmap = decodeImage(cacheFileUri, uri);
232+
bitmap = decodeImage(cacheFileUri);
232233
}
233234
if (bitmap == null || bitmap.getWidth() <= 0 || bitmap.getHeight() <= 0) {
234235
log(LOG_LOAD_IMAGE_FROM_NETWORK);
@@ -238,7 +239,7 @@ private Bitmap tryLoadBitmap() throws TaskCancelledException {
238239
options.isCacheOnDisc() && tryCacheImageOnDisc(imageFile) ? cacheFileUri : uri;
239240

240241
checkTaskNotActual();
241-
bitmap = decodeImage(imageUriForDecoding, uri);
242+
bitmap = decodeImage(imageUriForDecoding);
242243

243244
if (bitmap == null || bitmap.getWidth() <= 0 || bitmap.getHeight() <= 0) {
244245
fireFailEvent(FailType.DECODING_ERROR, null);
@@ -278,9 +279,9 @@ private File getImageFileInDiscCache() {
278279
return imageFile;
279280
}
280281

281-
private Bitmap decodeImage(String imageUri, String originalImageUri) throws IOException {
282+
private Bitmap decodeImage(String imageUri) throws IOException {
282283
ViewScaleType viewScaleType = imageAware.getScaleType();
283-
ImageDecodingInfo decodingInfo = new ImageDecodingInfo(memoryCacheKey, imageUri, originalImageUri, targetSize, viewScaleType,
284+
ImageDecodingInfo decodingInfo = new ImageDecodingInfo(memoryCacheKey, imageUri, uri, targetSize, viewScaleType,
284285
getDownloader(), options);
285286
return decoder.decode(decodingInfo);
286287
}

library/src/com/nostra13/universalimageloader/core/decode/ImageDecodingInfo.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import android.annotation.TargetApi;
1919
import android.graphics.BitmapFactory.Options;
2020
import android.os.Build;
21+
2122
import com.nostra13.universalimageloader.core.DisplayImageOptions;
2223
import com.nostra13.universalimageloader.core.assist.ImageScaleType;
2324
import com.nostra13.universalimageloader.core.assist.ImageSize;
@@ -34,7 +35,7 @@ public class ImageDecodingInfo {
3435

3536
private final String imageKey;
3637
private final String imageUri;
37-
private final String originalImageUri;
38+
private final String originalImageUri;
3839
private final ImageSize targetSize;
3940

4041
private final ImageScaleType imageScaleType;
@@ -50,7 +51,7 @@ public ImageDecodingInfo(String imageKey, String imageUri, String originalImageU
5051
ImageDownloader downloader, DisplayImageOptions displayOptions) {
5152
this.imageKey = imageKey;
5253
this.imageUri = imageUri;
53-
this.originalImageUri = originalImageUri;
54+
this.originalImageUri = originalImageUri;
5455
this.targetSize = targetSize;
5556

5657
this.imageScaleType = displayOptions.getImageScaleType();
@@ -101,10 +102,10 @@ public String getImageUri() {
101102
return imageUri;
102103
}
103104

104-
/** @return The original uri that the request wanted */
105-
public String getOriginalImageUri() {
106-
return originalImageUri;
107-
}
105+
/** @return The original image URI which was passed to ImageLoader */
106+
public String getOriginalImageUri() {
107+
return originalImageUri;
108+
}
108109

109110
/**
110111
* @return Target size for image. Decoded bitmap should close to this size according to {@linkplain ImageScaleType

0 commit comments

Comments
 (0)