Skip to content

Commit b1999ad

Browse files
committed
Clean code
1 parent 5cea0ac commit b1999ad

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

library/src/main/java/com/nostra13/universalimageloader/core/ImageLoader.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import android.text.TextUtils;
2222
import android.view.View;
2323
import android.widget.ImageView;
24+
2425
import com.nostra13.universalimageloader.cache.disc.DiskCache;
2526
import com.nostra13.universalimageloader.cache.memory.MemoryCache;
2627
import com.nostra13.universalimageloader.core.assist.FailReason;
@@ -204,8 +205,8 @@ public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions
204205
* @throws IllegalArgumentException if passed <b>imageAware</b> is null
205206
*/
206207
public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions options,
207-
ImageLoadingListener listener, ImageLoadingProgressListener progressListener) {
208-
displayImage(uri,imageAware,options,null,listener,progressListener);
208+
ImageLoadingListener listener, ImageLoadingProgressListener progressListener) {
209+
displayImage(uri, imageAware, options, null, listener, progressListener);
209210
}
210211

211212
/**
@@ -219,7 +220,7 @@ public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions
219220
* decoding and displaying. If <b>null</b> - default display image options
220221
* {@linkplain ImageLoaderConfiguration.Builder#defaultDisplayImageOptions(DisplayImageOptions)
221222
* from configuration} will be used.
222-
* @param targetImageSize {@linkplain ImageSize} Image target size. If <b>null</b> - size will depend on the view
223+
* @param targetSize {@linkplain ImageSize} Image target size. If <b>null</b> - size will depend on the view
223224
* @param listener {@linkplain ImageLoadingListener Listener} for image loading process. Listener fires
224225
* events on UI thread if this method is called on UI thread.
225226
* @param progressListener {@linkplain com.nostra13.universalimageloader.core.listener.ImageLoadingProgressListener
@@ -231,8 +232,7 @@ public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions
231232
* @throws IllegalArgumentException if passed <b>imageAware</b> is null
232233
*/
233234
public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions options,
234-
ImageSize targetImageSize,
235-
ImageLoadingListener listener, ImageLoadingProgressListener progressListener) {
235+
ImageSize targetSize, ImageLoadingListener listener, ImageLoadingProgressListener progressListener) {
236236
checkConfiguration();
237237
if (imageAware == null) {
238238
throw new IllegalArgumentException(ERROR_WRONG_ARGUMENTS);
@@ -256,10 +256,7 @@ public void displayImage(String uri, ImageAware imageAware, DisplayImageOptions
256256
return;
257257
}
258258

259-
ImageSize targetSize;
260-
if (targetImageSize != null) {
261-
targetSize = targetImageSize;
262-
}else {
259+
if (targetSize == null) {
263260
targetSize = ImageSizeUtils.defineTargetSizeForView(imageAware, configuration.getMaxImageSize());
264261
}
265262
String memoryCacheKey = MemoryCacheUtils.generateKey(uri, targetSize);
@@ -333,6 +330,7 @@ public void displayImage(String uri, ImageView imageView) {
333330
public void displayImage(String uri, ImageView imageView, ImageSize targetImageSize) {
334331
displayImage(uri, new ImageViewAware(imageView), null, targetImageSize, null, null);
335332
}
333+
336334
/**
337335
* Adds display image task to execution pool. Image will be set to ImageView when it's turn.<br />
338336
* <b>NOTE:</b> {@link #init(ImageLoaderConfiguration)} method must be called before this method call

0 commit comments

Comments
 (0)