重构remotingcommand协议解析部分。

Author: vintagewang

rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/protocol/RemotingCommand.java

@@ -174,6 +174,20 @@ public void writeCustomHeader(CommandCustomHeader customHeader) {
         this.customHeader = customHeader;
     }
 
+    private static final String StringName = String.class.getCanonicalName();//
+
+    private static final String IntegerName1 = Integer.class.getCanonicalName();//
+    private static final String IntegerName2 = int.class.getCanonicalName();//
+
+    private static final String LongName1 = Long.class.getCanonicalName();//
+    private static final String LongName2 = long.class.getCanonicalName();//
+
+    private static final String BooleanName1 = Boolean.class.getCanonicalName();//
+    private static final String BooleanName2 = boolean.class.getCanonicalName();//
+
+    private static final String DoubleName1 = Double.class.getCanonicalName();//
+    private static final String DoubleName2 = double.class.getCanonicalName();//
+
 
     public CommandCustomHeader decodeCommandCustomHeader(Class<? extends CommandCustomHeader> classHeader)
             throws RemotingCommandException {
@@ -203,37 +217,27 @@ public CommandCustomHeader decodeCommandCustomHeader(Class<? extends CommandCust
                                     throw new RemotingCommandException("the custom field <" + fieldName
                                             + "> is null");
                                 }
+
+                                continue;
                             }
 
                             field.setAccessible(true);
-                            String type = field.getType().getSimpleName();
+                            String type = field.getType().getCanonicalName();
                             Object valueParsed = null;
 
-                            if (type.equals("String")) {
+                            if (type.equals(StringName)) {
                                 valueParsed = value;
                             }
-                            else if (type.equals("Integer")) {
-                                valueParsed = Integer.parseInt(value);
-                            }
-                            else if (type.equals("Long")) {
-                                valueParsed = Long.parseLong(value);
-                            }
-                            else if (type.equals("Boolean")) {
-                                valueParsed = Boolean.parseBoolean(value);
-                            }
-                            else if (type.equals("Double")) {
-                                valueParsed = Double.parseDouble(value);
-                            }
-                            else if (type.equals("int")) {
+                            else if (type.equals(IntegerName1) || type.equals(IntegerName2)) {
                                 valueParsed = Integer.parseInt(value);
                             }
-                            else if (type.equals("long")) {
+                            else if (type.equals(LongName1) || type.equals(LongName2)) {
                                 valueParsed = Long.parseLong(value);
                             }
-                            else if (type.equals("boolean")) {
+                            else if (type.equals(BooleanName1) || type.equals(BooleanName2)) {
                                 valueParsed = Boolean.parseBoolean(value);
                             }
-                            else if (type.equals("double")) {
+                            else if (type.equals(DoubleName1) || type.equals(DoubleName2)) {
                                 valueParsed = Double.parseDouble(value);
                             }
                             else {