File tree Expand file tree Collapse file tree 2 files changed +15
-11
lines changed Expand file tree Collapse file tree 2 files changed +15
-11
lines changed Original file line number Diff line number Diff line change @@ -3,7 +3,7 @@ import { debounce } from '@/utils'
3
3
export default {
4
4
data ( ) {
5
5
return {
6
- sidebarElm : null
6
+ $_sidebarElm : null
7
7
}
8
8
} ,
9
9
mounted ( ) {
@@ -14,16 +14,18 @@ export default {
14
14
} , 100 )
15
15
window . addEventListener ( 'resize' , this . __resizeHandler )
16
16
17
- this . sidebarElm = document . getElementsByClassName ( 'sidebar-container' ) [ 0 ]
18
- this . sidebarElm && this . sidebarElm . addEventListener ( 'transitionend' , this . sidebarResizeHandler )
17
+ this . $_sidebarElm = document . getElementsByClassName ( 'sidebar-container' ) [ 0 ]
18
+ this . $_sidebarElm && this . $_sidebarElm . addEventListener ( 'transitionend' , this . $_sidebarResizeHandler )
19
19
} ,
20
20
beforeDestroy ( ) {
21
21
window . removeEventListener ( 'resize' , this . __resizeHandler )
22
22
23
- this . sidebarElm && this . sidebarElm . removeEventListener ( 'transitionend' , this . sidebarResizeHandler )
23
+ this . $_sidebarElm && this . $_sidebarElm . removeEventListener ( 'transitionend' , this . $_sidebarResizeHandler )
24
24
} ,
25
25
methods : {
26
- sidebarResizeHandler ( e ) {
26
+ // use $_ for mixins properties
27
+ // https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
28
+ $_sidebarResizeHandler ( e ) {
27
29
if ( e . propertyName === 'width' ) {
28
30
this . __resizeHandler ( )
29
31
}
Original file line number Diff line number Diff line change @@ -12,26 +12,28 @@ export default {
12
12
}
13
13
} ,
14
14
beforeMount ( ) {
15
- window . addEventListener ( 'resize' , this . resizeHandler )
15
+ window . addEventListener ( 'resize' , this . $_resizeHandler )
16
16
} ,
17
17
beforeDestroy ( ) {
18
- window . removeEventListener ( 'resize' , this . resizeHandler )
18
+ window . removeEventListener ( 'resize' , this . $_resizeHandler )
19
19
} ,
20
20
mounted ( ) {
21
- const isMobile = this . isMobile ( )
21
+ const isMobile = this . $_isMobile ( )
22
22
if ( isMobile ) {
23
23
store . dispatch ( 'app/toggleDevice' , 'mobile' )
24
24
store . dispatch ( 'app/closeSideBar' , { withoutAnimation : true } )
25
25
}
26
26
} ,
27
27
methods : {
28
- isMobile ( ) {
28
+ // use $_ for mixins properties
29
+ // https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
30
+ $_isMobile ( ) {
29
31
const rect = body . getBoundingClientRect ( )
30
32
return rect . width - 1 < WIDTH
31
33
} ,
32
- resizeHandler ( ) {
34
+ $_resizeHandler ( ) {
33
35
if ( ! document . hidden ) {
34
- const isMobile = this . isMobile ( )
36
+ const isMobile = this . $_isMobile ( )
35
37
store . dispatch ( 'app/toggleDevice' , isMobile ? 'mobile' : 'desktop' )
36
38
37
39
if ( isMobile ) {
You can’t perform that action at this time.
0 commit comments