Skip to content

Commit a6be6af

Browse files
committed
1 parent d0651ad commit a6be6af

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/components/Charts/mixins/resize.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { debounce } from '@/utils'
33
export default {
44
data() {
55
return {
6-
sidebarElm: null
6+
$_sidebarElm: null
77
}
88
},
99
mounted() {
@@ -14,16 +14,18 @@ export default {
1414
}, 100)
1515
window.addEventListener('resize', this.__resizeHandler)
1616

17-
this.sidebarElm = document.getElementsByClassName('sidebar-container')[0]
18-
this.sidebarElm && this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
17+
this.$_sidebarElm = document.getElementsByClassName('sidebar-container')[0]
18+
this.$_sidebarElm && this.$_sidebarElm.addEventListener('transitionend', this.$_sidebarResizeHandler)
1919
},
2020
beforeDestroy() {
2121
window.removeEventListener('resize', this.__resizeHandler)
2222

23-
this.sidebarElm && this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
23+
this.$_sidebarElm && this.$_sidebarElm.removeEventListener('transitionend', this.$_sidebarResizeHandler)
2424
},
2525
methods: {
26-
sidebarResizeHandler(e) {
26+
// use $_ for mixins properties
27+
// https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
28+
$_sidebarResizeHandler(e) {
2729
if (e.propertyName === 'width') {
2830
this.__resizeHandler()
2931
}

src/layout/mixin/ResizeHandler.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,28 @@ export default {
1212
}
1313
},
1414
beforeMount() {
15-
window.addEventListener('resize', this.resizeHandler)
15+
window.addEventListener('resize', this.$_resizeHandler)
1616
},
1717
beforeDestroy() {
18-
window.removeEventListener('resize', this.resizeHandler)
18+
window.removeEventListener('resize', this.$_resizeHandler)
1919
},
2020
mounted() {
21-
const isMobile = this.isMobile()
21+
const isMobile = this.$_isMobile()
2222
if (isMobile) {
2323
store.dispatch('app/toggleDevice', 'mobile')
2424
store.dispatch('app/closeSideBar', { withoutAnimation: true })
2525
}
2626
},
2727
methods: {
28-
isMobile() {
28+
// use $_ for mixins properties
29+
// https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
30+
$_isMobile() {
2931
const rect = body.getBoundingClientRect()
3032
return rect.width - 1 < WIDTH
3133
},
32-
resizeHandler() {
34+
$_resizeHandler() {
3335
if (!document.hidden) {
34-
const isMobile = this.isMobile()
36+
const isMobile = this.$_isMobile()
3537
store.dispatch('app/toggleDevice', isMobile ? 'mobile' : 'desktop')
3638

3739
if (isMobile) {

0 commit comments

Comments
 (0)