Skip to content

Commit 28a24c3

Browse files
author
epriestley
committed
Fix a couple of other missing getApplicationTransactionCommentObject() implementations
Summary: See PHI165. See D18715. These objects (projects, blogs) also need implementations now. (I thought about making this method `abstract` or doing try/catch to maybe make this more robust, but I think this should be the end of it, and those changes have mild complexity/compatibility/risk issues.) Test Plan: Changed `bin/search index` to index only one document of each type, ran `bin/search index --all --force`, saw no more comment-related errors. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D18729
1 parent 1d213dc commit 28a24c3

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/applications/phame/storage/PhameBlogTransaction.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ public function getApplicationTransactionType() {
1515
return PhabricatorPhameBlogPHIDType::TYPECONST;
1616
}
1717

18+
public function getApplicationTransactionCommentObject() {
19+
return null;
20+
}
21+
1822
public function getBaseTransactionClass() {
1923
return 'PhameBlogTransactionType';
2024
}

src/applications/project/storage/PhabricatorProjectTransaction.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@ public function getApplicationTransactionType() {
1919
return PhabricatorProjectProjectPHIDType::TYPECONST;
2020
}
2121

22+
public function getApplicationTransactionCommentObject() {
23+
return null;
24+
}
25+
2226
public function getBaseTransactionClass() {
2327
return 'PhabricatorProjectTransactionType';
2428
}

0 commit comments

Comments
 (0)