Skip to content

Commit d77f409

Browse files
kevmoorkirov
authored andcommitted
chore: analyzer fixes for Dart transformer
1 parent 25c709c commit d77f409

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

modules/angular2/src/transform/directive_processor/transformer.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ library angular2.transform.directive_processor.transformer;
22

33
import 'dart:async';
44

5-
import 'package:angular2/src/transform/common/formatter.dart';
65
import 'package:angular2/src/transform/common/logging.dart' as log;
76
import 'package:angular2/src/transform/common/names.dart';
87
import 'package:angular2/src/transform/common/options.dart';

modules/angular2/src/transform/reflection_remover/codegen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class _ReflectorVisitor extends Object with SimpleAstVisitor<Expression> {
7777

7878
@override
7979
Expression visitPropertyAccess(PropertyAccess node) {
80-
if (node == null || node.target == null) return;
80+
if (node == null || node.target == null) return null;
8181
return node.target;
8282
}
8383

modules/angular2/src/transform/template_compiler/generator.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,15 +160,15 @@ class _TemplateExtractVisitor extends Object with RecursiveAstVisitor<Object> {
160160
// TODO(kegluneq): Remove this limitation.
161161
if (node.name is! Label || node.name.label is! SimpleIdentifier) {
162162
logger.error(
163-
'Angular 2 currently only supports simple identifiers in directives',
163+
'Angular 2 currently only supports simple identifiers in directives.'
164164
' Source: ${node}');
165165
return null;
166166
}
167167
var keyString = '${node.name.label}';
168168
if (keyString == 'inline' || keyString == 'url') {
169169
if (node.expression is! SimpleStringLiteral) {
170170
logger.error(
171-
'Angular 2 currently only supports string literals in directives',
171+
'Angular 2 currently only supports string literals in directives.'
172172
' Source: ${node}');
173173
return null;
174174
}

modules/angular2/src/transform/template_compiler/recording_reflection_capabilities.dart

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,20 @@ import 'package:angular2/src/reflection/types.dart';
88
/// reflectively accessed at runtime.
99
class RecordingReflectionCapabilities implements ReflectionCapabilities {
1010
/// The names of all requested `getter`s.
11-
final List<String> getterNames = [];
11+
final List<String> getterNames = <String>[];
1212
/// The names of all requested `setter`s.
13-
final List<String> setterNames = [];
13+
final List<String> setterNames = <String>[];
1414
/// The names of all requested `method`s.
15-
final List<String> methodNames = [];
15+
final List<String> methodNames = <String>[];
1616

17-
void _notImplemented(String name) {
18-
throw 'Not implemented: $name';
19-
}
17+
_notImplemented(String name) => throw 'Not implemented: $name';
2018

2119
Function factory(Type type) => _notImplemented('factory');
2220

2321
List<List> parameters(typeOrFunc) => _notImplemented('parameters');
2422

2523
List annotations(typeOrFunc) => _notImplemented('annotations');
2624

27-
static GetterFn _nullGetter = (Object p) => null;
28-
static SetterFn _nullSetter = (Object p, v) => null;
29-
static MethodFn _nullMethod = (Object p, List a) => null;
30-
3125
GetterFn getter(String name) {
3226
getterNames.add(name);
3327
return _nullGetter;
@@ -43,3 +37,7 @@ class RecordingReflectionCapabilities implements ReflectionCapabilities {
4337
return _nullMethod;
4438
}
4539
}
40+
41+
_nullGetter(Object p) => null;
42+
_nullSetter(Object p, v) => null;
43+
_nullMethod(Object p, List a) => null;

0 commit comments

Comments
 (0)