Fixed stack overflow when saving project settings.

Fixes googlesamples#304
Bug: 145695256
Change-Id: I153d8a085b834796546cae4ed160128f83c277d8

Author: Stewart Miles

CHANGELOG.md

@@ -1,3 +1,7 @@
+# Version 1.2.135 - Dec 5, 2019
+## Bug Fixes
+* All Components: Fixed stack overflow when loading project settings.
+
 # Version 1.2.134 - Dec 4, 2019
 ## Bug Fixes
 * All Components: Fixed an issue which caused project settings to be cleared

source/VersionHandlerImpl/src/ProjectSettings.cs

@@ -741,7 +741,7 @@ public void DeleteKeys(IEnumerable<string> names) {
         /// <param name="save">Whether to save the settings.</param>
         internal static void DeleteAllProjectKeys(bool save = true) {
             lock (classLock) {
-                LoadIfEmpty();
+                if (save) LoadIfEmpty();
                 foreach (var key in new List<string>(projectSettings.Keys)) {
                     projectSettings.DeleteKey(key);
                 }