Synchronized Version Handler log level at load time.

This changes the VersionHandlerImpl class to set the Logger level when the
class is constructed rather than when the first message is logged.
This also ensures that all changes in log level are propagated to the
underlying Logger instance when the VersionHandlerImpl.Log() method isn't used.

Change-Id: I889a76485536dd85b152c5bc45359e181e428769

Author: Stewart Miles

source/VersionHandlerImpl/src/VersionHandlerImpl.cs

@@ -1504,14 +1504,23 @@ private string LibraryPrefix {
     // Settings used by this module.
     internal static ProjectSettings settings = new ProjectSettings("Google.VersionHandler.");
 
+    /// <summary>
+    ///    Logger for this module.
+    /// </summary>
+    private static Logger logger = new Logger();
+
     /// <summary>
     /// Enables / disables assets imported at multiple revisions / versions.
     /// In addition, this module will read text files matching _manifest_
     /// and remove files from older manifest files.
     /// </summary>
     static VersionHandlerImpl() {
         Log("Loaded VersionHandlerImpl", verbose: true);
-        RunOnMainThread.Run(() => { UpdateVersionedAssetsOnUpdate(); }, runNow: false);
+        RunOnMainThread.Run(() => {
+                // Load log preferences.
+                VerboseLoggingEnabled = VerboseLoggingEnabled;
+                UpdateVersionedAssetsOnUpdate();
+            }, runNow: false);
     }
 
     static void UpdateVersionedAssetsOnUpdate() {
@@ -1658,7 +1667,10 @@ public static bool VerboseLoggingEnabled {
         get { return System.Environment.CommandLine.Contains("-batchmode") ||
                 settings.GetBool(PREFERENCE_VERBOSE_LOGGING_ENABLED,
                                  defaultValue: false); }
-        set { settings.SetBool(PREFERENCE_VERBOSE_LOGGING_ENABLED, value); }
+        set {
+            settings.SetBool(PREFERENCE_VERBOSE_LOGGING_ENABLED, value);
+            logger.Level = value ? LogLevel.Verbose : LogLevel.Info;
+        }
     }
 
     /// <summary>
@@ -1701,11 +1713,6 @@ public static IEnumerable<string> UpdateCompleteMethods {
         }
     }
 
-    /// <summary>
-    /// Logger for this module.
-    /// </summary>
-    private static Logger logger = new Logger();
-
     /// <summary>
     /// Whether to also log to a file in the project.
     /// </summary>
@@ -1723,7 +1730,6 @@ internal static bool LogToFile {
     /// <param name="level">Severity of the message.</param>
     internal static void Log(string message, bool verbose = false,
                              LogLevel level = LogLevel.Info) {
-        logger.Level = VerboseLoggingEnabled ? LogLevel.Verbose : LogLevel.Info;
         logger.Log(message, level: verbose ? LogLevel.Verbose : level);
     }