Correct constant checking

toniperic · web-flow · commit d06347f10ef2 · 2017-04-27T10:13:47.000+02:00
Prior to this change I would be getting `Constant CURLOPT_CONNECTTIMEOUT_MS already defined` since PHP would try to re-define a constant.
diff --git a/lib/Net/URLChecker.php b/lib/Net/URLChecker.php
@@ -66,7 +66,7 @@ private function getHTTPResponseCode($url)
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
         // The PHP doc indicates that CURLOPT_CONNECTTIMEOUT_MS constant is added in cURL 7.16.2
         // available since PHP 5.2.3.
-        if (!defined(CURLOPT_CONNECTTIMEOUT_MS)) {
+        if (!defined('CURLOPT_CONNECTTIMEOUT_MS')) {
             define('CURLOPT_CONNECTTIMEOUT_MS', 156);  // default value for CURLOPT_CONNECTTIMEOUT_MS
         }
         curl_setopt($ch, CURLOPT_CONNECTTIMEOUT_MS, self::CONNECT_TIMEOUT_MS);

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ private function getHTTPResponseCode($url)`
`66`	`66`	`curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);`
`67`	`67`	`// The PHP doc indicates that CURLOPT_CONNECTTIMEOUT_MS constant is added in cURL 7.16.2`
`68`	`68`	`// available since PHP 5.2.3.`
`69`		`- if (!defined(CURLOPT_CONNECTTIMEOUT_MS)) {`
	`69`	`+ if (!defined('CURLOPT_CONNECTTIMEOUT_MS')) {`
`70`	`70`	`define('CURLOPT_CONNECTTIMEOUT_MS', 156); // default value for CURLOPT_CONNECTTIMEOUT_MS`
`71`	`71`	`}`
`72`	`72`	`curl_setopt($ch, CURLOPT_CONNECTTIMEOUT_MS, self::CONNECT_TIMEOUT_MS);`