[1.8.x] + fix issue AsyncHttpClient#631

AsyncHttpClient#631
"Grizzly provider aggressively set cookie missing domain and path to /"

Author: oleksiys

src/main/java/com/ning/http/client/providers/grizzly/GrizzlyAsyncHttpProvider.java

@@ -1096,15 +1096,8 @@ private void convertCookies(final Collection<Cookie> cookies,
                                     final org.glassfish.grizzly.http.Cookie[] gCookies) {
             int idx = 0;
             for (final Cookie cookie : cookies) {
-                final org.glassfish.grizzly.http.Cookie gCookie =
-                        new org.glassfish.grizzly.http.Cookie(cookie.getName(), cookie.getValue());
-                gCookie.setDomain(cookie.getDomain());
-                gCookie.setPath(cookie.getPath());
-                gCookie.setVersion(1);
-                gCookie.setMaxAge(cookie.getMaxAge());
-                gCookie.setSecure(cookie.isSecure());
-                gCookies[idx] = gCookie;
-                idx++;
+                gCookies[idx++] = new org.glassfish.grizzly.http.Cookie(
+                        cookie.getName(), cookie.getValue());
             }
 
         }
@@ -1326,7 +1319,7 @@ protected void onInitialLineParsed(HttpHeader httpHeader,
                             try {
                                 context.result(handler.onCompleted());
                                 context.done();
-                            } catch (Exception e) {
+                            } catch (Throwable e) {
                                 context.abort(e);
                             }
                         }
@@ -1459,7 +1452,7 @@ protected void onHttpHeadersParsed(HttpHeader httpHeader,
                                         "WebSocket protocol error: unexpected HTTP response status during handshake.");
                         context.result(null);
                     }
-                } catch (Exception e) {
+                } catch (Throwable e) {
                     httpHeader.setSkipRemainder(true);
                     context.abort(e);
                 }
@@ -1531,7 +1524,7 @@ protected boolean onHttpPacketParsed(HttpHeader httpHeader, FilterChainContext c
                 if (handler != null) {
                     try {
                         context.result(handler.onCompleted());
-                    } catch (Exception e) {
+                    } catch (Throwable e) {
                         context.abort(e);
                     }
                 } else {

src/test/java/com/ning/http/client/async/grizzly/GrizzlyAsyncProviderBasicTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012 Sonatype, Inc. All rights reserved.
+ * Copyright (c) 2012-2014 Sonatype, Inc. All rights reserved.
  *
  * This program is licensed to you under the Apache License Version 2.0,
  * and you may not use this file except in compliance with the Apache License Version 2.0.
@@ -57,9 +57,4 @@ public void customize(TCPNIOTransport transport, FilterChainBuilder builder) {
     @Test(groups = { "standalone", "default_provider", "async" }, enabled = false)
     public void asyncDoPostBasicGZIPTest() throws Throwable {
     }
-    
-    @Test(groups = { "standalone", "default_provider", "async" }, enabled = false)
-    public void asyncDoGetCookieTest() throws Throwable {
-        // FIXME server replies with a foo=bar cookie and yet Grizzly decodes it into foo=value; domain=/; path=/
-    }
 }