Skip to content

Commit 6ad3aca

Browse files
committed
Add 404 for GET /:resource
1 parent 840ff0a commit 6ad3aca

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/router.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ low.mixin({ createId: utils.createId })
1212
module.exports = function(source) {
1313
// Create router
1414
var router = express.Router()
15-
15+
1616
// Add middlewares
1717
router.use(bodyParser.json({limit: '10mb'}))
1818
router.use(bodyParser.urlencoded({ extended: false }))
@@ -41,6 +41,11 @@ module.exports = function(source) {
4141
// GET /*?*&_end=
4242
// GET /*?*&_start=&_end=
4343
function list(req, res, next) {
44+
// Test if resource exists
45+
if (!db.object.hasOwnProperty(req.params.resource)) {
46+
return res.sendStatus(404)
47+
}
48+
4449
// Filters list
4550
var filters = {}
4651

test/index.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ describe('Server', function() {
5959
.expect(db.posts)
6060
.expect(200, done)
6161
})
62+
63+
it('should respond with 404 if resource is not found', function(done) {
64+
request(server)
65+
.get('/undefined')
66+
.expect(404, done)
67+
})
6268
})
6369

6470
describe('GET /:resource?attr=&attr=', function() {

0 commit comments

Comments
 (0)