Skip to content

Commit 3170616

Browse files
authored
Merge pull request microsoft#182 from Microsoft/dev
Merge dev into master
2 parents 5d79db1 + d8cf756 commit 3170616

File tree

5 files changed

+29
-11
lines changed

5 files changed

+29
-11
lines changed

demo/code-demo/style/layout.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ header
269269
}
270270

271271
#mainContent {
272-
width: 90%;
272+
width: 86.7%;
273273
margin-left: 0.8%;
274274
}
275275

@@ -304,7 +304,7 @@ header
304304
}
305305

306306
#steps-nav-bar {
307-
width: 9%;
307+
width: 13.3%;
308308
font-size: 90%;
309309
padding-right: 0.8%;
310310
border-right: 1px solid #E5E5E5;

dist/powerbi.js

Lines changed: 12 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -467,9 +467,18 @@ export abstract class Embed {
467467
*/
468468
private setIframe(isLoad: boolean): void {
469469
if(!this.iframe) {
470-
const iframeHtml = `<iframe style="width:100%;height:100%;" src="${this.config.embedUrl}" scrolling="no" allowfullscreen="true"></iframe>`;
471-
this.element.innerHTML = iframeHtml;
472-
this.iframe = <HTMLIFrameElement>this.element.childNodes[0];
470+
var iframeContent = document.createElement("iframe");
471+
var embedUrl = this.config.embedUrl;
472+
iframeContent.setAttribute("style", "width:100%;height:100%;");
473+
iframeContent.setAttribute("src", embedUrl);
474+
iframeContent.setAttribute("scrolling", "no");
475+
iframeContent.setAttribute("allowfullscreen", "true");
476+
var node = this.element;
477+
while(node.firstChild) {
478+
node.removeChild(node.firstChild);
479+
}
480+
node.appendChild(iframeContent);
481+
this.iframe = <HTMLIFrameElement>node.firstChild;
473482
}
474483

475484
if(isLoad){

0 commit comments

Comments
 (0)