Almost all tests passing

Author: brianc

lib/native/client.js

@@ -63,6 +63,16 @@ Client.prototype.connect = function(cb) {
     return self.emit('error', err);
   };
 
+  var result
+  if (!cb) {
+    var resolve, reject
+    cb = (err) => err ? reject(err) : resolve()
+    result = new global.Promise(function(res, rej) {
+      resolve = res
+      reject = rej
+    })
+  }
+
   this.connectionParameters.getLibpqConnectionString(function(err, conString) {
     if(err) return onError(err);
     self.native.connect(conString, function(err) {
@@ -95,6 +105,8 @@ Client.prototype.connect = function(cb) {
       if(cb) cb();
     });
   });
+
+  return result
 };
 
 //send a query to the server
@@ -135,6 +147,15 @@ Client.prototype.end = function(cb) {
   if(!this._connected) {
     this.once('connect', this.end.bind(this, cb));
   }
+  var result;
+  if (!cb) {
+    var resolve, reject
+    cb = (err) => err ? reject(err) : resolve()
+    result = new global.Promise(function(res, rej) {
+      resolve = res
+      reject = rej
+    })
+  }
   this.native.end(function() {
     //send an error to the active query
     if(self._hasActiveQuery()) {
@@ -145,6 +166,7 @@ Client.prototype.end = function(cb) {
     self.emit('end');
     if(cb) cb();
   });
+  return result
 };
 
 Client.prototype._hasActiveQuery = function() {

test/integration/client/error-handling-tests.js

@@ -16,6 +16,24 @@ var createErorrClient = function() {
 
 const suite = new helper.Suite('error handling')
 
+suite.test('query receives error on client shutdown', false, function(done) {
+  var client = new Client();
+  client.connect(assert.success(function() {
+    const config = {
+      text: 'select pg_sleep(5)',
+      name: 'foobar'
+    }
+    client.query(new pg.Query(config), assert.calls(function(err, res) {
+      assert(err instanceof Error)
+      done()
+    }));
+    setTimeout(() => {
+      client.end()
+      assert.emits(client, 'end');
+    }, 50)
+  }));
+});
+
 ;(function () {
   var client = createErorrClient();
 
@@ -83,7 +101,7 @@ suite.test('non-error calls supplied callback', function(done) {
 
 suite.test('when connecting to an invalid host with callback', function (done) {
   var client = new Client({
-    host: 'asldkfjasdf!!#1308140.com'
+    host: '!#%!@#%'
   });
   client.connect(function(error, client) {
     assert(error instanceof Error);
@@ -109,24 +127,6 @@ suite.test('non-query error', function(done) {
     })
 });
 
-
-suite.test('query receives error on client shutdown', false, function(done) {
-  var client = new Client();
-  client.connect(function(err) {
-    if (err) {
-      return done(err)
-    }
-    client.query('SELECT pg_sleep(5)', assert.calls(function(err, res) {
-      assert(err instanceof Error)
-      done()
-    }));
-    setTimeout(() => {
-      client.end()
-      assert.emits(client, 'end');
-    }, 50)
-  });
-});
-
 suite.test('within a simple query', (done) => {
   var client = createErorrClient();
 

test/integration/client/promise-api-tests.js

@@ -40,10 +40,11 @@ suite.test('connected client does not reject promise after connection', (done) =
       setTimeout(() => {
         client.on('error', (e) => {
           assert(e instanceof Error)
+          client.end()
           done()
         })
         // manually kill the connection
-        client.connection.stream.end()
+        client.emit('error', new Error('something bad happened...but not really'))
       }, 50)
     })
 })

test/integration/client/query-error-handling-prepared-statement-tests.js

@@ -5,7 +5,7 @@ var util = require('util');
 var suite = new helper.Suite();
 
 suite.test('client end during query execution of prepared statement', function(done) {
-  var client = new Client(helper.args);
+  var client = new Client();
   client.connect(assert.success(function() {
 
     var sleepQuery = 'select pg_sleep($1)';
@@ -18,11 +18,11 @@ suite.test('client end during query execution of prepared statement', function(d
 
     var queryInstance = new Query(queryConfig, assert.calls(function (err, result) {
       assert.equal(err.message, 'Connection terminated');
+      done();
     }))
 
     var query1 = client.query(queryInstance);
 
-
     query1.on('error', function (err) {
       assert.fail('Prepared statement should not emit error');
     });
@@ -35,7 +35,7 @@ suite.test('client end during query execution of prepared statement', function(d
       assert.fail('Prepared statement when executed should not return before being killed');
     });
 
-    client.end(done);
+    client.end();
   }));
 });
 

test/native/connection-tests.js

@@ -45,7 +45,7 @@ class Suite {
   run(test, cb) {
     process.stdout.write('  ' + test.name + ' ')
     if (!test.action) {
-      process.stdout.write('? - SKIPPED')
+      process.stdout.write('? - SKIPPED\n')
       return cb()
     }