not isset

Mannes Brak · Mannes Brak · commit a1ae336bd9a7 · 2017-11-16T10:20:19.000+01:00
diff --git a/lib/Saml2/LogoutRequest.php b/lib/Saml2/LogoutRequest.php
@@ -366,7 +366,7 @@ public function isValid(\Symfony\Component\HttpFoundation\Request $request, $ret
                 }
             }
 
-            if (isset($request->get('Signature'))) {
+            if (null !== $request->get('Signature')) {
                 $signatureValid = OneLogin_Saml2_Utils::validateBinarySign("SAMLRequest", $request, $idpData, $retrieveParametersFromServer);
                 if (!$signatureValid) {
                     throw new OneLogin_Saml2_ValidationError(

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ public function isValid(\Symfony\Component\HttpFoundation\Request $request, $ret`
`366`	`366`	`}`
`367`	`367`	`}`
`368`	`368`
`369`		`- if (isset($request->get('Signature'))) {`
	`369`	`+ if (null !== $request->get('Signature')) {`
`370`	`370`	`$signatureValid = OneLogin_Saml2_Utils::validateBinarySign("SAMLRequest", $request, $idpData, $retrieveParametersFromServer);`
`371`	`371`	`if (!$signatureValid) {`
`372`	`372`	`throw new OneLogin_Saml2_ValidationError(`