Skip to content

Commit 0406a7f

Browse files
ronerjrtimols
authored andcommitted
Improvements on GitlabProjectHook (timols#328)
- Adding new attributes on GitlabProjectHook - Adding new signature on addProjectHook method - Adding new signature on editProjectHook method
1 parent 6567a9b commit 0406a7f

File tree

2 files changed

+64
-10
lines changed

2 files changed

+64
-10
lines changed

src/main/java/org/gitlab/api/GitlabAPI.java

Lines changed: 34 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2391,7 +2391,7 @@ public GitlabProjectHook addProjectHook(GitlabProject project, String url, Strin
23912391
.to(tailUrl, GitlabProjectHook.class);
23922392
}
23932393

2394-
public GitlabProjectHook addProjectHook(Serializable projectId, String url, boolean pushEvents, boolean issuesEvents, boolean mergeRequestEvents, boolean noteEvents, boolean tagPushEvents, boolean sslVerification, String token) throws IOException {
2394+
public GitlabProjectHook addProjectHook(Serializable projectId, String url, boolean pushEvents, boolean issuesEvents, boolean mergeRequestEvents, boolean noteEvents, boolean tagPushEvents, boolean sslVerification, boolean jobEvents, boolean pipelineEvents, boolean wikiPageEvents, String token) throws IOException {
23952395
String tailUrl = GitlabProject.URL + "/" + sanitizeProjectId(projectId) + GitlabProjectHook.URL;
23962396

23972397
return dispatch()
@@ -2402,18 +2402,46 @@ public GitlabProjectHook addProjectHook(Serializable projectId, String url, bool
24022402
.with("note_events", noteEvents ? "true" : "false")
24032403
.with("tag_push_events", tagPushEvents ? "true" : "false")
24042404
.with("enable_ssl_verification", sslVerification ? "true" : "false")
2405+
.with("job_events", jobEvents ? "true" : "false")
2406+
.with("pipeline_events", pipelineEvents ? "true" : "false")
2407+
.with("wiki_page_events", wikiPageEvents ? "true" : "false")
24052408
.with("token", token)
24062409
.to(tailUrl, GitlabProjectHook.class);
24072410
}
24082411

2409-
public GitlabProjectHook editProjectHook(GitlabProject project, String hookId, String url) throws IOException {
2410-
Query query = new Query()
2411-
.append("url", url);
2412+
public GitlabProjectHook addProjectHook(Serializable projectId, String url, GitlabProjectHook hook, String token) throws IOException {
2413+
return this.addProjectHook(projectId, url, hook.getPushEvents(), hook.getIssueEvents(), hook.isMergeRequestsEvents(),
2414+
hook.isNoteEvents(), hook.isTagPushEvents(), hook.isSslVerificationEnabled(), hook.isJobEvents(),
2415+
hook.isPipelineEvents(), hook.isWikiPageEvents(), token);
2416+
}
24122417

2418+
public GitlabProjectHook editProjectHook(GitlabProject project, String hookId, String url,
2419+
boolean pushEvents, boolean issuesEvents, boolean mergeRequestEvents, boolean noteEvents,
2420+
boolean tagPushEvents, boolean sslVerification, boolean jobEvents, boolean pipelineEvents,
2421+
boolean wikiPageEvents, String token) throws IOException {
2422+
Query query = new Query();
2423+
query.append("url", url);
2424+
query.append("push_events", String.valueOf(pushEvents));
2425+
query.append("issues_events", String.valueOf(issuesEvents));
2426+
query.append("merge_request_events", String.valueOf(mergeRequestEvents));
2427+
query.append("note_events", String.valueOf(noteEvents));
2428+
query.append("tag_push_events", String.valueOf(tagPushEvents));
2429+
query.append("enable_ssl_verification", String.valueOf(sslVerification));
2430+
query.append("job_events", String.valueOf(jobEvents));
2431+
query.append("pipeline_events", String.valueOf(pipelineEvents));
2432+
query.append("wiki_page_events", String.valueOf(wikiPageEvents));
2433+
query.append("token", token);
24132434
String tailUrl = GitlabProject.URL + "/" + project.getId() + GitlabProjectHook.URL + "/" + hookId + query.toString();
24142435
return retrieve().method(PUT).to(tailUrl, GitlabProjectHook.class);
24152436
}
24162437

2438+
public GitlabProjectHook editProjectHook(GitlabProject project, GitlabProjectHook projectHook, String token) throws IOException {
2439+
return editProjectHook(project, projectHook.getId(), projectHook.getUrl(), projectHook.getPushEvents(),
2440+
projectHook.getIssueEvents(), projectHook.isMergeRequestsEvents(), projectHook.isNoteEvents(),
2441+
projectHook.isTagPushEvents(), projectHook.isSslVerificationEnabled(), projectHook.isJobEvents(),
2442+
projectHook.isWikiPageEvents(), projectHook.isPipelineEvents(), token);
2443+
}
2444+
24172445
public void deleteProjectHook(GitlabProjectHook hook) throws IOException {
24182446
String tailUrl = GitlabProject.URL + "/" + hook.getProjectId() + GitlabProjectHook.URL + "/" + hook.getId();
24192447
retrieve().method(DELETE).to(tailUrl, Void.class);
@@ -3969,7 +3997,7 @@ public GitlabRunner getRunnerDetail(int id) throws IOException {
39693997
* @param before If not null, include only events created before a particular date.
39703998
* @param after If not null, include only events created before a
39713999
* particular date.
3972-
* @param sort If null, uses the server's default, which is "desc"
4000+
* @param sortOrder If null, uses the server's default, which is "desc"
39734001
*/
39744002
public List<GitlabEvent> getEvents(GitlabProject project,
39754003
GitlabEvent.ActionType action,
@@ -3990,7 +4018,7 @@ public List<GitlabEvent> getEvents(GitlabProject project,
39904018
* @param before If not null, include only events created before a particular date.
39914019
* @param after If not null, include only events created before a
39924020
* particular date.
3993-
* @param sort If null, uses the server's default, which is "desc"
4021+
* @param sortOrder If null, uses the server's default, which is "desc"
39944022
*/
39954023
public List<GitlabEvent> getEvents(GitlabProject project,
39964024
GitlabEvent.ActionType action,

src/main/java/org/gitlab/api/models/GitlabProjectHook.java

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,25 @@ public class GitlabProjectHook {
2525

2626
@JsonProperty("tag_push_events")
2727
private boolean tagPushEvents;
28-
28+
2929
@JsonProperty("created_at")
3030
private Date createdAt;
3131

3232
@JsonProperty("enable_ssl_verification")
3333
private boolean sslVerificationEnabled;
3434

35+
@JsonProperty("note_events")
36+
private boolean noteEvents;
37+
38+
@JsonProperty("job_events")
39+
private boolean jobEvents;
40+
41+
@JsonProperty("pipeline_events")
42+
private boolean pipelineEvents;
43+
44+
@JsonProperty("wiki_page_events")
45+
private boolean wikiPageEvents;
46+
3547
public String getId() {
3648
return id;
3749
}
@@ -80,15 +92,14 @@ public void setMergeRequestsEvents(boolean mergeRequestsEvents) {
8092
this.mergeRequestsEvents = mergeRequestsEvents;
8193
}
8294

83-
8495
public boolean isTagPushEvents() {
8596
return tagPushEvents;
8697
}
87-
98+
8899
public void setTagPushEvents(boolean tagPushEvents) {
89100
this.tagPushEvents = tagPushEvents;
90101
}
91-
102+
92103
public Date getCreatedAt() {
93104
return createdAt;
94105
}
@@ -105,4 +116,19 @@ public void setSslVerificationEnabled(boolean sslVerificationEnabled) {
105116
this.sslVerificationEnabled = sslVerificationEnabled;
106117
}
107118

119+
public boolean isNoteEvents() { return noteEvents; }
120+
121+
public void setNoteEvents(boolean noteEvents) { this.noteEvents = noteEvents; }
122+
123+
public boolean isJobEvents() { return jobEvents; }
124+
125+
public void setJobEvents(boolean jobEvents) { this.jobEvents = jobEvents; }
126+
127+
public boolean isPipelineEvents() { return pipelineEvents; }
128+
129+
public void setPipelineEvents(boolean pipelineEvents) { this.pipelineEvents = pipelineEvents; }
130+
131+
public boolean isWikiPageEvents() { return wikiPageEvents; }
132+
133+
public void setWikiPageEvents(boolean wikiPageEvents) { this.wikiPageEvents = wikiPageEvents; }
108134
}

0 commit comments

Comments
 (0)