Skip to content

Commit ba650c6

Browse files
author
Stephane Landelle
committed
Upgrade TestNG 6.8.8, get rid of transitive JUnit
1 parent 9a880b3 commit ba650c6

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,8 @@
126126
<dependency>
127127
<groupId>org.testng</groupId>
128128
<artifactId>testng</artifactId>
129-
<version>5.8</version>
129+
<version>6.8.8</version>
130130
<scope>test</scope>
131-
<classifier>jdk15</classifier>
132131
</dependency>
133132
<dependency>
134133
<groupId>org.eclipse.jetty</groupId>

src/test/java/com/ning/http/client/async/SimpleAsyncHttpClientTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414

1515
import static java.nio.charset.StandardCharsets.*;
1616

17-
import static junit.framework.Assert.assertTrue;
18-
import static org.testng.Assert.assertEquals;
19-
import static org.testng.Assert.fail;
17+
import static org.testng.Assert.*;
2018
import static org.testng.AssertJUnit.assertNotNull;
2119
import static org.testng.AssertJUnit.assertNotSame;
2220

@@ -220,11 +218,12 @@ public void onBytesReceived(Uri uri, long amount, long current, long total) {
220218

221219
@Test(groups = { "standalone", "default_provider" })
222220
public void testNullUrl() throws Exception {
223-
SimpleAsyncHttpClient client = new SimpleAsyncHttpClient.Builder().setProviderClass(getProviderClass()).build().derive().build();
221+
SimpleAsyncHttpClient client = null;
224222
try {
225-
assertTrue(true);
223+
client = new SimpleAsyncHttpClient.Builder().setProviderClass(getProviderClass()).build().derive().build();
226224
} finally {
227-
client.close();
225+
if (client != null)
226+
client.close();
228227
}
229228
}
230229

0 commit comments

Comments
 (0)