Check for possibly undefined variable

francescopepe · web-flow · commit 6b6a618663f6 · 2017-01-03T23:42:02.000+01:00
diff --git a/lib/Saml2/Response.php b/lib/Saml2/Response.php
@@ -236,7 +236,7 @@ public function isValid($requestId = null)
                         $scnData = $subjectConfirmationDataNodes->item(0);
                         if ($scnData->hasAttribute('InResponseTo')) {
                             $inResponseTo = $scnData->getAttribute('InResponseTo');
-                            if ($responseInResponseTo != $inResponseTo) {
+                            if (isset($responseInResponseTo) && $responseInResponseTo != $inResponseTo) {
                                 continue;
                             }
                         }

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ public function isValid($requestId = null)`
`236`	`236`	`$scnData = $subjectConfirmationDataNodes->item(0);`
`237`	`237`	`if ($scnData->hasAttribute('InResponseTo')) {`
`238`	`238`	`$inResponseTo = $scnData->getAttribute('InResponseTo');`
`239`		`- if ($responseInResponseTo != $inResponseTo) {`
	`239`	`+ if (isset($responseInResponseTo) && $responseInResponseTo != $inResponseTo) {`
`240`	`240`	`continue;`
`241`	`241`	`}`
`242`	`242`	`}`