Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Commit a7e7eeb

Browse files
author
Mikko Koppanen
committed
revert the string comparison
1 parent e93758a commit a7e7eeb

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

php_memcached.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -235,20 +235,16 @@ static PHP_INI_MH(OnUpdateSerializer)
235235
{
236236
if (!new_value) {
237237
MEMC_G(serializer) = SERIALIZER_DEFAULT;
238-
} else if (new_value_length == sizeof("php") - 1 &&
239-
strncmp(new_value, "php", sizeof("php") - 1) == 0) {
238+
} else if (!strcmp(new_value, "php")) {
240239
MEMC_G(serializer) = SERIALIZER_PHP;
241240
#ifdef HAVE_MEMCACHE_IGBINARY
242-
} else if (new_value_length == sizeof("igbinary") - 1 &&
243-
strncmp(new_value, "igbinary", sizeof("igbinary") - 1) == 0) {
241+
} else if (!strcmp(new_value, "igbinary")) {
244242
MEMC_G(serializer) = SERIALIZER_IGBINARY;
245243
#endif // IGBINARY
246244
#ifdef HAVE_JSON_API
247-
} else if (new_value_length == sizeof("json") - 1 &&
248-
strncmp(new_value, "json", sizeof("json") - 1) == 0) {
245+
} else if (!strcmp(new_value, "json")) {
249246
MEMC_G(serializer) = SERIALIZER_JSON;
250-
} else if (new_value_length == sizeof("json_array") - 1 &&
251-
strncmp(new_value, "json_array", sizeof("json_array") - 1) == 0) {
247+
} else if (!strcmp(new_value, "json_array")) {
252248
MEMC_G(serializer) = SERIALIZER_JSON_ARRAY;
253249
#endif // JSON
254250
} else {

0 commit comments

Comments
 (0)