fix: Handle eval removal properly, remove "remove-evals" script and WebpackShellPlugin (Kocal#398)

* fix(webpack): define `global` as `window` to prevent eval() issues

This way, we get rid of "remove-evals" script that was sometimes working and sometimes not.

* chore: remove WebpackShellPlugin & "remove-evals" script

Author: Kocal

template/package.json

@@ -89,7 +89,6 @@
     "vue-template-compiler": "^2.5.17",
     "webpack": "^4.20.2",
     "webpack-chrome-extension-reloader": "^0.8.3",
-    "webpack-cli": "^3.1.2",
-    "webpack-shell-plugin": "^0.5.0"
+    "webpack-cli": "^3.1.2"
   }
 }

template/scripts/remove-evals.js

@@ -1,7 +1,6 @@
 const webpack = require('webpack');
 const ejs = require('ejs');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
-const WebpackShellPlugin = require('webpack-shell-plugin');
 const CopyWebpackPlugin = require('copy-webpack-plugin');
 const ChromeExtensionReloader = require('webpack-chrome-extension-reloader');
 const { VueLoaderPlugin } = require('vue-loader');
@@ -55,6 +54,9 @@ const config = {
     ],
   },
   plugins: [
+    new webpack.DefinePlugin({
+      global: 'window',
+    }),
     new VueLoaderPlugin(),
     new MiniCssExtractPlugin({
       filename: '[name].css',
@@ -78,9 +80,6 @@ const config = {
         },
       },
     ]),
-    new WebpackShellPlugin({
-      onBuildEnd: ['node scripts/remove-evals.js'],
-    }),
   ],
 };