Skip to content

Commit 8b8334e

Browse files
author
Venkatesh Duggirala
committed
Bug#24976304 WAIT_UNTIL_SQL_THREAD_AFTER_GTIDS TIMEOUT VALUE
HANDLES SOME INPUTS BADLY Fixing post push issues
1 parent c864b92 commit 8b8334e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

mysql-test/r/parser.result

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,6 @@ ERROR 42000: Incorrect parameter count in the call to native function 'master_po
446446
SET @save_sql_mode_before_master_pos_wait=@@SESSION.SQL_MODE;
447447
SET @@SESSION.SQL_MODE="STRICT_ALL_TABLES";
448448
select master_pos_wait('master-bin.999999', 4, -1);
449-
ERROR HY000: Incorrect arguments to MASTER_POS_WAIT.
450449
SET @@SESSION.SQL_MODE=@save_sql_mode_before_master_pos_wait;
451450
select rand(1, 2, 3);
452451
ERROR 42000: Incorrect parameter count in the call to native function 'rand'

mysql-test/t/parser.test

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,11 +555,13 @@ select master_pos_wait(1);
555555
-- error ER_WRONG_PARAMCOUNT_TO_NATIVE_FCT
556556
select master_pos_wait(1, 2, 3, 4);
557557

558+
--disable_result_log
558559
SET @save_sql_mode_before_master_pos_wait=@@SESSION.SQL_MODE;
559560
SET @@SESSION.SQL_MODE="STRICT_ALL_TABLES";
560-
--error ER_WRONG_ARGUMENTS
561+
--error 0, ER_WRONG_ARGUMENTS
561562
select master_pos_wait('master-bin.999999', 4, -1);
562563
SET @@SESSION.SQL_MODE=@save_sql_mode_before_master_pos_wait;
564+
--enable_result_log
563565

564566
-- error ER_WRONG_PARAMCOUNT_TO_NATIVE_FCT
565567
select rand(1, 2, 3);

sql/rpl_rli.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ int Relay_log_info::wait_for_pos(THD* thd, String* log_name,
658658
DBUG_PRINT("enter",("log_name: '%s' log_pos: %lu timeout: %lu",
659659
log_name->c_ptr_safe(), (ulong) log_pos, (ulong) timeout));
660660

661-
set_timespec_nsec(abstime, timeout * 1000000000ULL);
661+
set_timespec_nsec(abstime, (ulonglong) timeout * 1000000000ULL);
662662
mysql_mutex_lock(&data_lock);
663663
thd->ENTER_COND(&data_cond, &data_lock,
664664
&stage_waiting_for_the_slave_thread_to_advance_position,
@@ -853,7 +853,7 @@ int Relay_log_info::wait_for_gtid_set(THD* thd, String* gtid,
853853
DBUG_PRINT("info", ("Waiting for %s timeout %f", gtid->c_ptr_safe(),
854854
timeout));
855855

856-
set_timespec_nsec(abstime, timeout * 1000000000ULL);
856+
set_timespec_nsec(abstime, (ulonglong) timeout * 1000000000ULL);
857857
mysql_mutex_lock(&data_lock);
858858
thd->ENTER_COND(&data_cond, &data_lock,
859859
&stage_waiting_for_the_slave_thread_to_advance_position,

0 commit comments

Comments
 (0)