Bug#25372805 PERFORMANCE SCHEMA 5.6.35 UNITTEST PFT-T FAILING

Unit test pfs-t is failing, with the following error printed:
  not ok 179 - no locker (no thread owner)

The root cause is the test case for sockets,
which was not updated to follow a change in implementation in the code,
as the behavior changed.

Now, somehow this test failure went unnoticed,
and after investigation it turns out that the unit tests
programs to not return the test exit_status() on exit,
masking test failures to the automated build scripts.

This fix adjusts the failing test case,
and fixes all performance schema unit tests
to properly return the test exit_status().

Author: marcalff

storage/perfschema/unittest/pfs-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2016, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -1344,8 +1344,9 @@ void test_locker_disabled()
   ok(socket_A1 != NULL, "instrumented");
   /* Socket thread owner has not been set */
   socket_locker= psi->start_socket_wait(&socket_state, socket_A1, PSI_SOCKET_SEND, 12, "foo.cc", 12);
-  ok(socket_locker == NULL, "no locker (no thread owner)");
-  
+  ok(socket_locker != NULL, "locker (owner not used)");
+  psi->end_socket_wait(socket_locker, 10);
+
   /* Pretend the running thread is not instrumented */
   /* ---------------------------------------------- */
 
@@ -1665,6 +1666,6 @@ int main(int, char **)
   plan(216);
   MY_INIT("pfs-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_account-oom-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -111,6 +111,6 @@ int main(int, char **)
   plan(6);
   MY_INIT("pfs_account-oom-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_connect_attr-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2011, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -341,5 +341,5 @@ int main(int, char **)
     diag("skipping the cp1251 tests : missing character set");
   plan(59 + (cs_cp1251 ? 10 : 0));
   do_all_tests();
-  return 0;
+  return (exit_status());
 }

storage/perfschema/unittest/pfs_host-oom-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -111,6 +111,6 @@ int main(int, char **)
   plan(6);
   MY_INIT("pfs_host-oom-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_instr-oom-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2016, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -686,6 +686,6 @@ int main(int, char **)
   plan(20);
   MY_INIT("pfs_instr-oom-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_instr-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2016, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -416,6 +416,6 @@ int main(int, char **)
   plan(103);
   MY_INIT("pfs_instr-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_instr_class-oom-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -67,6 +67,6 @@ int main(int, char **)
   plan(9);
   MY_INIT("pfs_instr_info-oom-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_instr_class-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -673,6 +673,6 @@ int main(int, char **)
   plan(181);
   MY_INIT("pfs_instr_info-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_misc-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -66,6 +66,6 @@ int main(int, char **)
   plan(2);
   MY_INIT("pfs_misc-t");
   do_all_tests();
-  return exit_status();
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_timer-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2008, 2011, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -117,6 +117,6 @@ int main(int, char **)
   plan(5);
   MY_INIT("pfs_timer-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }
 

storage/perfschema/unittest/pfs_user-oom-t.cc

@@ -1,4 +1,4 @@
-/* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved.
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -110,6 +110,6 @@ int main(int, char **)
   plan(6);
   MY_INIT("pfs_user-oom-t");
   do_all_tests();
-  return 0;
+  return (exit_status());
 }