Skip to content

Commit 3b33089

Browse files
committed
Don't show 'needs review' on DifferentialObjects
Summary: This text is overly repetitive and is not super important. Keeps the other states. Also - Easier to parse reviewers now - Mobile is less janky Test Plan: reload my list of diffs {F138756} Reviewers: epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D8707
1 parent c408168 commit 3b33089

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/applications/differential/view/DifferentialRevisionListView.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,10 @@ public function render() {
138138
$item->addAttribute($draft);
139139
}
140140

141-
$item->addAttribute($status_name);
141+
/* Most things 'Need Review', so accept it's the default */
142+
if ($status != ArcanistDifferentialRevisionStatus::NEEDS_REVIEW) {
143+
$item->addAttribute($status_name);
144+
}
142145

143146
// Author
144147
$author_handle = $this->handles[$revision->getAuthorPHID()];

0 commit comments

Comments
 (0)