Audit - add ability to add a package as an auditor

Summary: Fixes T4687. This was also pretty easy...!

Test Plan: made a package with a test user as owner. added package as owner. looked right on commit page. logged in as test user and verified audit showed up on home page.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: chad, epriestley, Korvin

Maniphest Tasks: T4687

Differential Revision: https://secure.phabricator.com/D8705

Author: bobtrahan

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -778,9 +778,9 @@ private function renderAddCommentPanel(
         'dynamic' => array(
           'add-auditors-tokenizer' => array(
             'actions' => array('add_auditors' => 1),
-            'src' => '/typeahead/common/usersorprojects/',
+            'src' => '/typeahead/common/usersprojectsorpackages/',
             'row' => 'add-auditors',
-            'placeholder' => pht('Type a user or project name...'),
+            'placeholder' => pht('Type a user, project, or package name...'),
           ),
           'add-ccs-tokenizer' => array(
             'actions' => array('add_ccs' => 1),

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

@@ -73,6 +73,11 @@ public function processRequest() {
         $need_users = true;
         $need_projs = true;
         break;
+      case 'usersprojectsorpackages':
+        $need_users = true;
+        $need_projs = true;
+        $need_packages = true;
+        break;
       case 'repositories':
         $need_repos = true;
         break;
@@ -309,6 +314,7 @@ public function processRequest() {
       $packages = id(new PhabricatorOwnersPackage())->loadAll();
       foreach ($packages as $package) {
         $results[] = id(new PhabricatorTypeaheadResult())
+          ->setIcon('pl-testplan')
           ->setName($package->getName())
           ->setURI('/owners/package/'.$package->getID().'/')
           ->setPHID($package->getPHID());

src/view/form/control/AphrontFormTokenizerControl.php

@@ -94,9 +94,11 @@ private function getDefaultPlaceholder() {
       'projects'        => pht('Type a project name...'),
       'repositories'    => pht('Type a repository name...'),
       'packages'        => pht('Type a package name...'),
+      'macros'          => pht('Type a macro name...'),
       'arcanistproject' => pht('Type an arc project name...'),
       'accountsorprojects' => pht('Type a user or project name...'),
-      'macros' => pht('Type a macro name...'),
+      'usersprojectsorpackages' =>
+        pht('Type a user, project, or package name...'),
     );
 
     return idx($map, $request);