Skip to content

Commit ae460fb

Browse files
committed
Fix str.isprintable
1 parent 563c8b1 commit ae460fb

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_unicode.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isascii
4242
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isdecimal
4343
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_islower
44+
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isprintable
4445
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_isspace
4546
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_issue28598_strsubclass_rhs
4647
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_istitle
@@ -68,6 +69,7 @@
6869
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_strip_whitespace
6970
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_subclass_add
7071
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_subscript
72+
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_surrogates
7173
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_title
7274
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_unicode_repr
7375
*graalpython.lib-python.3.test.test_unicode.UnicodeTest.test_upper

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1807,11 +1807,7 @@ static boolean doGeneric(Object self,
18071807
abstract static class IsPrintableNode extends PythonUnaryBuiltinNode {
18081808
@TruffleBoundary
18091809
private static boolean isPrintableChar(int i) {
1810-
if (UCharacter.isISOControl(i)) {
1811-
return false;
1812-
}
1813-
Character.UnicodeBlock block = Character.UnicodeBlock.of(i);
1814-
return block != null && block != Character.UnicodeBlock.SPECIALS;
1810+
return UCharacter.isPrintable(i);
18151811
}
18161812

18171813
@Specialization

0 commit comments

Comments
 (0)