-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Comparing changes
Open a pull request
base repository: brianc/node-postgres
base: master
head repository: mapmeld/node-postgres
compare: bmc/notice-not-error-instance
- 14 commits
- 20 files changed
- 5 contributors
Commits on Jan 28, 2020
-
Drop support for EOL versions of node (#2062)
* Drop support for EOL versions of node * Re-add testing for [email protected] * Revert changes to .travis.yml * Update packages/pg-pool/package.json Co-Authored-By: Charmander <[email protected]> Co-authored-by: Charmander <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c909aa6 - Browse repository at this point
Copy the full SHA c909aa6View commit details -
Remove password from stringified outputs (#2066)
* Remove password from stringified outputs Theres a security concern where if you're not careful and you include your client or pool instance in console.log or stack traces it might include the database password. To widen the pit of success I'm making that field non-enumerable. You can still get at it...it just wont show up "by accident" when you're logging things now. The backwards compatiblity impact of this is very small, but it is still technically somewhat an API change so...8.0. * Implement feedback * Fix more whitespace the autoformatter changed * Simplify code a bit * Remove password from stringified outputs (#2070) * Keep ConnectionParameters’s password property writable `Client` writes to it when `password` is a function. * Avoid creating password property on pool options when it didn’t exist previously. * Allow password option to be non-enumerable to avoid breaking uses like `new Pool(existingPool.options)`. * Make password property definitions consistent in formatting and configurability. Co-authored-by: Charmander <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 31eaa05 - Browse repository at this point
Copy the full SHA 31eaa05View commit details -
Make
native
non-enumerable (#2065)* Make `native` non-enumerable Making it non-enumerable means less spurious "Cannot find module" errors in your logs when iterating over `pg` objects. `Object.defineProperty` has been available since Node 0.12. See #1894 (comment) * Add test for `native` enumeration Co-authored-by: Gabe Gorelick <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e85afe1 - Browse repository at this point
Copy the full SHA e85afe1View commit details -
Use class-extends to wrap Pool (#1541)
* Use class-extends to wrap Pool * Minimize diff * Test `BoundPool` inheritance Co-authored-by: Charmander <[email protected]> Co-authored-by: Brian C <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 224703f - Browse repository at this point
Copy the full SHA 224703fView commit details -
Continue support for creating a pg.Pool from another instance’s optio…
…ns (#2076) * Add failing test for creating a `BoundPool` from another instance’s settings * Continue support for creating a pg.Pool from another instance’s options by dropping the requirement for the `password` property to be enumerable.
Configuration menu - View commit details
-
Copy full SHA for 05c7665 - Browse repository at this point
Copy the full SHA 05c7665View commit details -
Use user name as default database when user is non-default (#1679)
Not entirely backwards-compatible.
Configuration menu - View commit details
-
Copy full SHA for c26caa8 - Browse repository at this point
Copy the full SHA c26caa8View commit details
Commits on Jan 30, 2020
-
Make native client password property consistent with others
i.e. configurable.
Configuration menu - View commit details
-
Copy full SHA for 94fbb24 - Browse repository at this point
Copy the full SHA 94fbb24View commit details -
Make notice messages not an instance of Error
Slight API cleanup to make a notice instance the same shape as it was, but not be an instance of error. This is a backwards incompatible change though I expect the impact to be minimal. Closes #1982
Configuration menu - View commit details
-
Copy full SHA for 9b8b7ec - Browse repository at this point
Copy the full SHA 9b8b7ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 305a832 - Browse repository at this point
Copy the full SHA 305a832View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffdb3fb - Browse repository at this point
Copy the full SHA ffdb3fbView commit details
Commits on Feb 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 80c046d - Browse repository at this point
Copy the full SHA 80c046dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f69c3 - Browse repository at this point
Copy the full SHA c1f69c3View commit details
Commits on Feb 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 17266c1 - Browse repository at this point
Copy the full SHA 17266c1View commit details
Commits on Feb 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ce8801f - Browse repository at this point
Copy the full SHA ce8801fView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...bmc/notice-not-error-instance