Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: brianc/node-postgres
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mapmeld/node-postgres
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bmc/notice-not-error-instance
Choose a head ref
  • 14 commits
  • 20 files changed
  • 5 contributors

Commits on Jan 28, 2020

  1. Drop support for EOL versions of node (#2062)

    * Drop support for EOL versions of node
    
    * Re-add testing for [email protected]
    
    * Revert changes to .travis.yml
    
    * Update packages/pg-pool/package.json
    
    Co-Authored-By: Charmander <[email protected]>
    
    Co-authored-by: Charmander <[email protected]>
    brianc and charmander committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    c909aa6 View commit details
    Browse the repository at this point in the history
  2. Remove password from stringified outputs (#2066)

    * Remove password from stringified outputs
    
    Theres a security concern where if you're not careful and you include your client or pool instance in console.log or stack traces it might include the database password.  To widen the pit of success I'm making that field non-enumerable.  You can still get at it...it just wont show up "by accident" when you're logging things now.
    
    The backwards compatiblity impact of this is very small, but it is still technically somewhat an API change so...8.0.
    
    * Implement feedback
    
    * Fix more whitespace the autoformatter changed
    
    * Simplify code a bit
    
    * Remove password from stringified outputs (#2070)
    
    * Keep ConnectionParameters’s password property writable
    
    `Client` writes to it when `password` is a function.
    
    * Avoid creating password property on pool options
    
    when it didn’t exist previously.
    
    * Allow password option to be non-enumerable
    
    to avoid breaking uses like `new Pool(existingPool.options)`.
    
    * Make password property definitions consistent
    
    in formatting and configurability.
    
    Co-authored-by: Charmander <[email protected]>
    brianc and charmander committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    31eaa05 View commit details
    Browse the repository at this point in the history
  3. Make native non-enumerable (#2065)

    * Make `native` non-enumerable
    
    Making it non-enumerable means less spurious "Cannot find module"
    errors in your logs when iterating over `pg` objects.
    
    `Object.defineProperty` has been available since Node 0.12.
    
    See #1894 (comment)
    
    * Add test for `native` enumeration
    
    Co-authored-by: Gabe Gorelick <[email protected]>
    brianc and gabegorelick committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    e85afe1 View commit details
    Browse the repository at this point in the history
  4. Use class-extends to wrap Pool (#1541)

    * Use class-extends to wrap Pool
    
    * Minimize diff
    
    * Test `BoundPool` inheritance
    
    Co-authored-by: Charmander <[email protected]>
    Co-authored-by: Brian C <[email protected]>
    3 people committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    224703f View commit details
    Browse the repository at this point in the history
  5. Continue support for creating a pg.Pool from another instance’s optio…

    …ns (#2076)
    
    * Add failing test for creating a `BoundPool` from another instance’s settings
    
    * Continue support for creating a pg.Pool from another instance’s options
    
    by dropping the requirement for the `password` property to be enumerable.
    charmander authored and brianc committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    05c7665 View commit details
    Browse the repository at this point in the history
  6. Use user name as default database when user is non-default (#1679)

    Not entirely backwards-compatible.
    charmander authored and brianc committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    c26caa8 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Make native client password property consistent with others

    i.e. configurable.
    charmander committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    94fbb24 View commit details
    Browse the repository at this point in the history
  2. Make notice messages not an instance of Error

    Slight API cleanup to make a notice instance the same shape as it was, but not be an instance of error.  This is a backwards incompatible change though I expect the impact to be minimal.
    
    Closes #1982
    brianc committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    9b8b7ec View commit details
    Browse the repository at this point in the history
  3. skip notice test in travis

    brianc committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    305a832 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ffdb3fb View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Configuration menu
    Copy the full SHA
    80c046d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1f69c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Emit notice messages on travis

    brianc committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    17266c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. Update package.json

    mapmeld authored Feb 18, 2020
    Configuration menu
    Copy the full SHA
    ce8801f View commit details
    Browse the repository at this point in the history
Loading