Skip to content

Commit 73218d1

Browse files
author
Amit Shuster
committed
Merged PR 22904: Playground - IE support fix
IE does not support array.prototype.find & array.prototype.findIndex
1 parent 59d05f5 commit 73218d1

File tree

3 files changed

+45
-42
lines changed

3 files changed

+45
-42
lines changed

‎demo/v2-demo/live_showcases/insight_to_action/showcase_insight_to_action.js‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,18 +118,18 @@ function embedInsightsToActionReport() {
118118
.then(function (pages) {
119119

120120
// Retrieve active page.
121-
let activePage = pages.find(function(page) {
121+
let activePage = pages.filter(function(page) {
122122
return page.isActive
123-
});
123+
})[0];
124124

125125
// Get page's visuals
126126
activePage.getVisuals()
127127
.then(function (visuals) {
128128

129129
// Retrieve the wanted visual.
130-
let visual = visuals.find(function(visual) {
130+
let visual = visuals.filter(function(visual) {
131131
return visual.name === tableVisualName;
132-
});
132+
})[0];
133133

134134
// Exports visual data
135135
visual.exportData(models.ExportDataType.Underlying).then(handleExportData);
@@ -191,7 +191,10 @@ function parseData(data) {
191191
// Filter the table's data - removing the 'filterValues' columns
192192
function filterTable(filterValues, table) {
193193
for (let i = 0; i < filterValues.length; i++) {
194-
valueIndex = table[0].findIndex(function(value) { return value === filterValues[i] });
194+
valueIndex = table[0].indexOf(
195+
table[0].filter(function(value) { return value === filterValues[i] })[0]
196+
);
197+
195198
for (let j = 0; j < table.length; j++) {
196199
table[j].splice(valueIndex, 1);
197200
}

‎demo/v2-demo/scripts/codesamples.js‎

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1565,9 +1565,9 @@ function _Page_GetFilters() {
15651565
report.getPages()
15661566
.then(function (pages) {
15671567
// Retrieve active page.
1568-
var activePage = pages.find(function(page) {
1568+
var activePage = pages.filter(function(page) {
15691569
return page.isActive
1570-
});
1570+
})[0];
15711571

15721572
activePage.getFilters()
15731573
.then(function (filters) {
@@ -1593,9 +1593,9 @@ function _Page_GetVisuals() {
15931593
report.getPages()
15941594
.then(function (pages) {
15951595
// Retrieve active page.
1596-
var activePage = pages.find(function(page) {
1596+
var activePage = pages.filter(function(page) {
15971597
return page.isActive
1598-
});
1598+
})[0];
15991599

16001600
activePage.getVisuals()
16011601
.then(function (visuals) {
@@ -1642,9 +1642,9 @@ function _Page_SetFilters() {
16421642
report.getPages()
16431643
.then(function (pages) {
16441644
// Retrieve active page.
1645-
var activePage = pages.find(function(page) {
1645+
var activePage = pages.filter(function(page) {
16461646
return page.isActive
1647-
});
1647+
})[0];
16481648

16491649
activePage.setFilters([filter])
16501650
.then(function () {
@@ -1670,9 +1670,9 @@ function _Page_RemoveFilters() {
16701670
report.getPages()
16711671
.then(function (pages) {
16721672
// Retrieve active page.
1673-
var activePage = pages.find(function(page) {
1673+
var activePage = pages.filter(function(page) {
16741674
return page.isActive
1675-
});
1675+
})[0];
16761676

16771677
activePage.removeFilters()
16781678
.then(function () {
@@ -2187,16 +2187,16 @@ function _Visual_GetSlicer() {
21872187
report.getPages()
21882188
.then(function (pages) {
21892189
// Retrieve active page.
2190-
var activePage = pages.find(function(page) {
2190+
var activePage = pages.filter(function(page) {
21912191
return page.isActive;
2192-
});
2192+
})[0];
21932193

21942194
activePage.getVisuals()
21952195
.then(function (visuals) {
21962196
// Retrieve the wanted visual.
2197-
var slicer = visuals.find(function(visual) {
2197+
var slicer = visuals.filter(function(visual) {
21982198
return visual.type == "slicer" && visual.name == "4d55baaa5eddde4cdf90";
2199-
});
2199+
})[0];
22002200

22012201
// Get the slicer state which contains the slicer filter.
22022202
slicer.getSlicerState()
@@ -2249,16 +2249,16 @@ function _Visual_SetSlicer() {
22492249
report.getPages()
22502250
.then(function (pages) {
22512251
// Retrieve active page.
2252-
var activePage = pages.find(function(page) {
2252+
var activePage = pages.filter(function(page) {
22532253
return page.isActive;
2254-
});
2254+
})[0];
22552255

22562256
activePage.getVisuals()
22572257
.then(function (visuals) {
22582258
// Retrieve the wanted visual.
2259-
var slicer = visuals.find(function(visual) {
2259+
var slicer = visuals.filter(function(visual) {
22602260
return visual.type == "slicer" && visual.name == "4d55baaa5eddde4cdf90";
2261-
});
2261+
})[0];
22622262

22632263
// Set the slicer state which contains the slicer filters.
22642264
slicer.setSlicerState({ filters: [filter]})
@@ -2308,17 +2308,17 @@ function _Visual_SetFilters() {
23082308
.then(function (pages) {
23092309

23102310
// Retrieve active page.
2311-
var activePage = pages.find(function(page) {
2311+
var activePage = pages.filter(function(page) {
23122312
return page.isActive
2313-
});
2313+
})[0];
23142314

23152315
activePage.getVisuals()
23162316
.then(function (visuals) {
23172317

23182318
// Retrieve the wanted visual.
2319-
var visual = visuals.find(function(visual) {
2319+
var visual = visuals.filter(function(visual) {
23202320
return visual.name == "VisualContainer4";
2321-
});
2321+
})[0];
23222322

23232323
// Set the filter for the visual.
23242324
// Pay attention that setFilters receives an array.
@@ -2351,17 +2351,17 @@ function _Visual_GetFilters() {
23512351
.then(function (pages) {
23522352

23532353
// Retrieve active page.
2354-
var activePage = pages.find(function(page) {
2354+
var activePage = pages.filter(function(page) {
23552355
return page.isActive
2356-
});
2356+
})[0];
23572357

23582358
activePage.getVisuals()
23592359
.then(function (visuals) {
23602360

23612361
// Retrieve the wanted visual.
2362-
var visual = visuals.find(function(visual) {
2362+
var visual = visuals.filter(function(visual) {
23632363
return visual.name == "VisualContainer4";
2364-
});
2364+
})[0];
23652365

23662366
visual.getFilters()
23672367
.then(function (filters) {
@@ -2392,17 +2392,17 @@ function _Visual_RemoveFilters() {
23922392
.then(function (pages) {
23932393

23942394
// Retrieve active page.
2395-
var activePage = pages.find(function(page) {
2395+
var activePage = pages.filter(function(page) {
23962396
return page.isActive
2397-
});
2397+
})[0];
23982398

23992399
activePage.getVisuals()
24002400
.then(function (visuals) {
24012401

24022402
// Retrieve the wanted visual.
2403-
var visual = visuals.find(function(visual) {
2403+
var visual = visuals.filter(function(visual) {
24042404
return visual.name == "VisualContainer4";
2405-
});
2405+
})[0];
24062406

24072407
visual.removeFilters()
24082408
.then(function () {
@@ -2436,17 +2436,17 @@ function _Visual_ExportData_Summarized() {
24362436
.then(function (pages) {
24372437

24382438
// Retrieve active page.
2439-
var activePage = pages.find(function(page) {
2439+
var activePage = pages.filter(function(page) {
24402440
return page.isActive
2441-
});
2441+
})[0];
24422442

24432443
activePage.getVisuals()
24442444
.then(function (visuals) {
24452445

24462446
// Retrieve the wanted visual.
2447-
var visual = visuals.find(function(visual) {
2447+
var visual = visuals.filter(function(visual) {
24482448
return visual.name == "VisualContainer4";
2449-
});
2449+
})[0];
24502450

24512451
// Exports visual data
24522452
visual.exportData(models.ExportDataType.Summarized)
@@ -2481,17 +2481,17 @@ function _Visual_ExportData_Underlying() {
24812481
.then(function (pages) {
24822482

24832483
// Retrieve active page.
2484-
var activePage = pages.find(function(page) {
2484+
var activePage = pages.filter(function(page) {
24852485
return page.isActive
2486-
});
2486+
})[0];
24872487

24882488
activePage.getVisuals()
24892489
.then(function (visuals) {
24902490

24912491
// Retrieve the wanted visual.
2492-
var visual = visuals.find(function(visual) {
2492+
var visual = visuals.filter(function(visual) {
24932493
return visual.name == "VisualContainer4";
2494-
});
2494+
})[0];
24952495

24962496
// Exports visual data
24972497
visual.exportData(models.ExportDataType.Underlying)

‎demo/v2-demo/scripts/session_utils.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ function FetchUrlIntoSession(url, updateCurrentToken) {
182182
{
183183
let embedContainerId = getEmbedContainerID(capitalizeFirstLetter(embedConfig.type));
184184

185-
let embedContainer = powerbi.embeds.find(function(embedElement) {return (embedElement.element.id == embedContainerId)});
185+
let embedContainer = powerbi.embeds.filter(function(embedElement) { return embedElement.element.id === embedContainerId; })[0];
186186
if (embedContainer)
187187
{
188188
embedContainer.setAccessToken(embedConfig.embedToken.token);

0 commit comments

Comments
 (0)