Skip to content

Commit 9a8dc1f

Browse files
committed
Change rules:
- do not force to use `.jsx` extension for React components. - do not enforce a defaultProps definition
1 parent adf1890 commit 9a8dc1f

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

packages/eslint-config-dina-base/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# eslint-config-dina-base
22

3-
[![npm version](https://badge.fury.io/js/eslint-config-airbnb-base.svg)](http://badge.fury.io/js/eslint-config-airbnb-base)
3+
[![npm version](https://badge.fury.io/js/eslint-config-dina-base.svg)](http://badge.fury.io/js/eslint-config-dina-base)
44

55
This package provides Digital Natives' base JS .eslintrc (without React plugins) as an extensible shared config.
66

packages/eslint-config-dina/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# eslint-config-dina
22

3-
[![npm version](https://badge.fury.io/js/eslint-config-airbnb.svg)](http://badge.fury.io/js/eslint-config-airbnb)
3+
[![npm version](https://badge.fury.io/js/eslint-config-dina.svg)](http://badge.fury.io/js/eslint-config-dina)
44

55
This package provides Digital Natives' .eslintrc as an extensible shared config.
66

packages/eslint-config-dina/rules/react.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ module.exports = {
301301

302302
// only .jsx files may have JSX
303303
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
304-
'react/jsx-filename-extension': ['error', { extensions: ['.jsx'] }],
304+
'react/jsx-filename-extension': 'off',
305305

306306
// prevent accidental JS comments from being injected into JSX as text
307307
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-comment-textnodes.md
@@ -371,9 +371,7 @@ module.exports = {
371371

372372
// Enforce a defaultProps definition for every prop that is not a required prop
373373
// https://github.com/yannickcr/eslint-plugin-react/blob/843d71a432baf0f01f598d7cf1eea75ad6896e4b/docs/rules/require-default-props.md
374-
'react/require-default-props': ['error', {
375-
forbidDefaultForRequired: true,
376-
}],
374+
'react/require-default-props': 'off',
377375

378376
// Forbids using non-exported propTypes
379377
// https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md

react/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ This style guide is mostly based on the standards that are currently prevalent i
8181

8282
## Naming
8383

84-
- **Extensions**: Use `.jsx` extension for React components. eslint: [`react/jsx-filename-extension`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md)
8584
- **Filename**: Use PascalCase for filenames. E.g., `ReservationCard.jsx`.
8685
- **Reference Naming**: Use PascalCase for React components and camelCase for their instances. eslint: [`react/jsx-pascal-case`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md)
8786

0 commit comments

Comments
 (0)