Skip to content

Commit 2fa895d

Browse files
author
Shahak Yosef
committed
Merged PR 99756: Release version 2.13.0
This PR contains: - Version bump for the latest models versoin (1.4.0) - Version bump for the javascript sdk - Fix broken playground (mirror gh-pages changes) - Remove survey banner as the survey ended.
1 parent c9f3ecb commit 2fa895d

File tree

9 files changed

+149
-106
lines changed

9 files changed

+149
-106
lines changed

demo/v2-demo/sample.html

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
<div id="playground-banner" onclick="openBannerLink();">
2-
<p id="playground-banner-text">Help us learn about your Power BI Embedded experience.&nbsp;</p><p id="playground-banner-text-underlined">Take our survey now!</p>
3-
<img id="playground-banner-close" src="images\close.png" onclick="closeBanner();"/>
4-
</div>
51
<div id="steps-nav-bar">
62
<div id="steps-ul-dev">
73
<ul id="steps-ul" class="steps-ul">
@@ -32,19 +28,4 @@ <h3>Welcome to the Power BI Embedded Playground</h3>
3228
</div>
3329

3430
<div id="mainContent">
35-
</div>
36-
37-
<script>
38-
var showBanner = true;
39-
function closeBanner() {
40-
showBanner = false;
41-
$("#playground-banner").hide();
42-
}
43-
44-
function openBannerLink() {
45-
if (!showBanner)
46-
return;
47-
48-
window.open("https://aka.ms/pbiesurvey_general", '_blank');
49-
}
50-
</script>
31+
</div>

demo/v2-demo/scripts/report.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ function OpenSamplesStep() {
3030
$("#embed-and-interact-steps-wrapper").hide();
3131

3232
$("#welcome-text").show();
33-
34-
if (window.innerWidth > 540)
35-
$("#playground-banner").show();
3633

3734
trackEvent(TelemetryEventName.InnerSectionOpen, { section: TelemetryInnerSection.Sample, src: TelemetryEventSource.UserClick });
3835
}

demo/v2-demo/scripts/session_utils.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
const reportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/SampleReport';
2-
const datasetUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/SampleCreate';
3-
const dashboardUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Dashboards/SampleDashboard';
4-
const tileUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Tiles/SampleTile';
5-
const qnaUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Datasets/SampleQna';
6-
const paginatedReportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/SampleRdlReport';
7-
const layoutShowcaseReportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/LayoutDemoReport';
8-
const insightToActionShowcaseReportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/InsightToActionReport';
9-
const themesShowcaseReportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/ThemesReport';
10-
const quickVisualCreatorShowcaseReportUrl = 'https://powerbiplaygroundbe.azurewebsites.net/api/Reports/EmptyReport';
1+
const reportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/SampleReport';
2+
const datasetUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/SampleCreate';
3+
const dashboardUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Dashboards/SampleDashboard';
4+
const tileUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Tiles/SampleTile';
5+
const qnaUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Datasets/SampleQna';
6+
const paginatedReportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/SampleRdlReport';
7+
const layoutShowcaseReportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/LayoutDemoReport';
8+
const insightToActionShowcaseReportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/InsightToActionReport';
9+
const themesShowcaseReportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/ThemesReport';
10+
const quickVisualCreatorShowcaseReportUrl = 'https://playgroundbe-bck-1.azurewebsites.net/Reports/EmptyReport';
1111

1212
var LastReportSampleUrl = null;
1313
var ReportRefreshTokenTimer = 0;
@@ -194,21 +194,21 @@ function SetTextBoxesFromSessionOrUrlParam(accessTokenSelector, embedUrlSelector
194194

195195
function FetchUrlIntoSession(url, updateCurrentToken) {
196196
return $.getJSON(url, function (embedConfig) {
197-
setSession(embedConfig.embedToken.token, embedConfig.embedUrl, embedConfig.id, embedConfig.dashboardId);
198-
SetSession(SessionKeys.SampleId, embedConfig.id);
197+
setSession(embedConfig.EmbedToken.Token, embedConfig.EmbedUrl, embedConfig.Id, embedConfig.DashboardId);
198+
SetSession(SessionKeys.SampleId, embedConfig.Id);
199199

200200
if (updateCurrentToken)
201201
{
202-
let embedContainerId = getEmbedContainerID(capitalizeFirstLetter(embedConfig.type));
202+
let embedContainerId = getEmbedContainerID(capitalizeFirstLetter(embedConfig.Type));
203203

204204
let embedContainer = powerbi.embeds.filter(function(embedElement) { return embedElement.element.id === embedContainerId; })[0];
205205
if (embedContainer)
206206
{
207-
embedContainer.setAccessToken(embedConfig.embedToken.token);
207+
embedContainer.setAccessToken(embedConfig.EmbedToken.Token);
208208
}
209209
}
210210

211-
if (embedConfig.type === "report" || embedConfig.type === "visual")
211+
if (embedConfig.Type === "report" || embedConfig.Type === "visual")
212212
{
213213
// Set single visual embed sample details.
214214
SetSession(SessionKeys.PageName, "ReportSectioneb8c865100f8508cc533");
@@ -217,7 +217,7 @@ function FetchUrlIntoSession(url, updateCurrentToken) {
217217
LastReportSampleUrl = url;
218218
}
219219

220-
TokenExpirationRefreshListener(embedConfig.minutesToExpiration, capitalizeFirstLetter(embedConfig.type));
220+
TokenExpirationRefreshListener(embedConfig.MinutesToExpiration, capitalizeFirstLetter(embedConfig.Type));
221221
});
222222
}
223223

demo/v2-demo/style/style.css

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1863,55 +1863,3 @@ input:checked + .slider.round {
18631863
position: absolute;
18641864
font-size: 14px;
18651865
}
1866-
1867-
/* Playground Banner */
1868-
1869-
#playground-banner {
1870-
height: 48px;
1871-
text-align: center;
1872-
color: #000000;
1873-
background-color: #FBEEB5;
1874-
padding: 12px;
1875-
border-bottom: solid 1px #F1F1F1;
1876-
cursor: pointer;
1877-
}
1878-
1879-
#playground-banner:hover {
1880-
background-color: #F7DE6D;
1881-
}
1882-
1883-
#playground-banner-text, #playground-banner-text-underlined {
1884-
font-size: 16px;
1885-
font-weight: 400;
1886-
display: inline-block;
1887-
}
1888-
1889-
#playground-banner-text-underlined {
1890-
text-decoration: underline;
1891-
font-weight: 600;
1892-
}
1893-
1894-
#playground-banner-close {
1895-
float: right;
1896-
margin-top: 4px;
1897-
margin-right: 8px;
1898-
}
1899-
1900-
@media only screen and (max-width: 675px) {
1901-
#playground-banner-text-underlined {
1902-
display: none;
1903-
}
1904-
}
1905-
1906-
1907-
@media only screen and (max-width: 605px) {
1908-
#playground-banner-text {
1909-
font-size: 14px;
1910-
}
1911-
}
1912-
1913-
@media only screen and (max-width: 540px) {
1914-
#playground-banner {
1915-
display: none;
1916-
}
1917-
}

dist/powerbi-client.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! powerbi-client v2.12.2 | (c) 2016 Microsoft Corporation MIT */
1+
/*! powerbi-client v2.13.0 | (c) 2016 Microsoft Corporation MIT */
22
declare module "util" {
33
import { HttpPostMessage } from 'http-post-message';
44
/**

0 commit comments

Comments
 (0)