Skip to content

Commit 3797706

Browse files
Ismaestroiramos
authored andcommitted
Remove SW (for the moment)
1 parent 64fc6aa commit 3797706

File tree

9 files changed

+99
-53
lines changed

9 files changed

+99
-53
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
![travis](https://travis-ci.org/Ismaestro/angular7-example-app.svg?branch=master)
4545
[![Coverage Status](https://coveralls.io/repos/github/Ismaestro/angular7-example-app/badge.svg?branch=master)](https://coveralls.io/github/Ismaestro/angular7-example-app?branch=master)
4646
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/9d190a60fc864060ac054ba17a4e92e4)](https://www.codacy.com/app/Ismaestro/angular7-example-app?utm_source=github.com&utm_medium=referral&utm_content=Ismaestro/angular7-example-app&utm_campaign=badger)
47-
[![Known Vulnerabilities](https://snyk.io/test/github/ismaestro/angular7-example-app/badge.svg)](https://snyk.io/test/github/ismaestro/angular7-example-app)
4847
[![Conventional Commits](https://img.shields.io/badge/Conventional%20Commits-1.0.0-yellow.svg)](https://conventionalcommits.org)
4948
[![dependency Status](https://david-dm.org/ismaestro/angular7-example-app.svg)](https://david-dm.org/ismaestro/angular7-example-app#info=dependencies)
5049
[![devDependency Status](https://david-dm.org/ismaestro/angular7-example-app/dev-status.svg)](https://david-dm.org/ismaestro/angular7-example-app#info=devDependencies)
@@ -60,7 +59,6 @@
6059
* Angular Universal (SSR)
6160
* Internationalization with the official i18n. Separated builds for english and spanish.
6261
* Lazy loading modules
63-
* Service Workers
6462
* More logical structure directory (from [here](https://itnext.io/choosing-a-highly-scalable-folder-structure-in-angular-d987de65ec7))
6563
* Basic example library
6664
* Following the [best practices](https://angular.io/guide/styleguide)!

firebase.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88
],
99
"rewrites": [
1010
{
11-
"source": "/",
12-
"destination": "/app.html"
11+
"source": "/es/**",
12+
"destination": "/es/index.html"
1313
},
1414
{
15-
"source": "**/es/**",
16-
"destination": "/es/index.html"
15+
"source": "/**",
16+
"destination": "/app.html"
1717
},
1818
{
1919
"source": "**",

functions/package-lock.json

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

functions/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
"@angular/platform-browser-dynamic": "7.2.7",
1717
"@angular/platform-server": "7.2.7",
1818
"@angular/router": "7.2.7",
19-
"@angular/service-worker": "7.2.8",
2019
"@angular/upgrade": "7.2.7",
2120
"@ismaestro/ngx-example-library": "1.0.0",
2221
"@ismaestro/ngx-scroll-to-first-invalid": "2.0.0",

ngsw-config.json

Lines changed: 0 additions & 25 deletions
This file was deleted.

package-lock.json

Lines changed: 93 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@
6666
"@angular/compiler-cli": "7.2.8",
6767
"@angular/language-service": "7.2.8",
6868
"@angular/material": "7.3.3",
69-
"@angular/service-worker": "7.2.8",
7069
"@ismaestro/ngx-example-library": "1.0.0",
7170
"@ngx-i18nsupport/ngx-i18nsupport": "1.1.2",
7271
"@types/html2canvas": "0.0.35",
@@ -99,6 +98,7 @@
9998
"path": "0.12.7",
10099
"protractor": "5.4.2",
101100
"standard-version": "5.0.1",
101+
"sw-precache": "^5.2.1",
102102
"ts-helpers": "1.1.2",
103103
"ts-loader": "5.3.3",
104104
"ts-node": "8.0.3",

src/app/app.module.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import {ErrorHandler, LOCALE_ID, NgModule, TRANSLATIONS} from '@angular/core';
22
import {AppRoutingModule} from './app-routing.module';
33
import {CoreModule} from './core/core.module';
44
import {AppComponent} from './app.component';
5-
import {ServiceWorkerModule} from '@angular/service-worker';
6-
import {environment} from '../environments/environment';
75
import {APP_CONFIG, AppConfig} from './configs/app.config';
86
import {SharedModule} from './shared/shared.module';
97
import {NgxExampleLibraryModule} from '@ismaestro/ngx-example-library';
@@ -18,7 +16,6 @@ declare const require;
1816
imports: [
1917
BrowserModule.withServerTransition({appId: 'angularexampleapp'}),
2018
FirebaseModule,
21-
ServiceWorkerModule.register('/ngsw-worker.js', {enabled: environment.production}),
2219
NgxExampleLibraryModule.forRoot({
2320
config: {
2421
say: 'hello'

src/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
https://az743702.vo.msecnd.net
4646
https://sentry.io
4747
48+
https://www.angularexampleapp.com
4849
ws://localhost:4200;
4950
">
5051
<meta name="viewport" content="width=device-width, initial-scale=1">

0 commit comments

Comments
 (0)