Optimize memory consumption

Author: staabm

src/Analyser/ResultCache/ResultCacheManager.php

@@ -10,8 +10,8 @@
 use PHPStan\Command\Output;
 use PHPStan\Dependency\ExportedNodeFetcher;
 use PHPStan\Dependency\RootExportedNode;
+use PHPStan\File\CouldNotReadFileException;
 use PHPStan\File\FileFinder;
-use PHPStan\File\FileReader;
 use PHPStan\File\FileWriter;
 use PHPStan\Internal\ComposerHelper;
 use PHPStan\PhpDoc\StubFilesProvider;
@@ -33,10 +33,9 @@
 use function is_file;
 use function is_string;
 use function ksort;
-use function sha1;
+use function sha1_file;
 use function sort;
 use function sprintf;
-use function str_replace;
 use function time;
 use function unlink;
 use function var_export;
@@ -789,10 +788,10 @@ private function getFileHash(string $path): string
 			return $this->fileHashes[$path];
 		}
 
-		$contents = FileReader::read($path);
-		$contents = str_replace("\r\n", "\n", $contents);
-
-		$hash = sha1($contents);
+		$hash = sha1_file($path);
+		if ($hash === false) {
+			throw new CouldNotReadFileException($path);
+		}
 		$this->fileHashes[$path] = $hash;
 
 		return $hash;

src/DependencyInjection/Configurator.php

@@ -5,12 +5,12 @@
 use Nette\DI\Config\Loader;
 use Nette\DI\Container as OriginalNetteContainer;
 use Nette\DI\ContainerLoader;
-use PHPStan\File\FileReader;
+use PHPStan\File\CouldNotReadFileException;
 use function array_keys;
 use function error_reporting;
 use function restore_error_handler;
 use function set_error_handler;
-use function sha1;
+use function sha1_file;
 use const E_USER_DEPRECATED;
 use const PHP_RELEASE_VERSION;
 use const PHP_VERSION_ID;
@@ -92,7 +92,13 @@ private function getAllConfigFilesHashes(): array
 	{
 		$hashes = [];
 		foreach ($this->allConfigFiles as $file) {
-			$hashes[$file] = sha1(FileReader::read($file));
+			$hash = sha1_file($file);
+
+			if ($hash === false) {
+				throw new CouldNotReadFileException($file);
+			}
+
+			$hashes[$file] = $hash;
 		}
 
 		return $hashes;

src/File/FileMonitor.php

@@ -6,7 +6,7 @@
 use function array_key_exists;
 use function array_keys;
 use function count;
-use function sha1;
+use function sha1_file;
 
 class FileMonitor
 {
@@ -81,7 +81,13 @@ public function getChanges(): FileMonitorResult
 
 	private function getFileHash(string $filePath): string
 	{
-		return sha1(FileReader::read($filePath));
+		$hash = sha1_file($filePath);
+
+		if ($hash === false) {
+			throw new CouldNotReadFileException($filePath);
+		}
+
+		return $hash;
 	}
 
 }

src/Reflection/BetterReflection/SourceLocator/OptimizedDirectorySourceLocatorFactory.php

@@ -3,9 +3,7 @@
 namespace PHPStan\Reflection\BetterReflection\SourceLocator;
 
 use PHPStan\Cache\Cache;
-use PHPStan\File\CouldNotReadFileException;
 use PHPStan\File\FileFinder;
-use PHPStan\File\FileReader;
 use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ConstantNameHelper;
 use function array_key_exists;
@@ -15,7 +13,7 @@
 use function php_strip_whitespace;
 use function preg_match_all;
 use function preg_replace;
-use function sha1;
+use function sha1_file;
 use function sprintf;
 use function strtolower;
 
@@ -42,12 +40,11 @@ public function createByDirectory(string $directory): NewOptimizedDirectorySourc
 		$files = $this->fileFinder->findFiles([$directory])->getFiles();
 		$fileHashes = [];
 		foreach ($files as $file) {
-			try {
-				$contents = FileReader::read($file);
-			} catch (CouldNotReadFileException) {
+			$hash = sha1_file($file);
+			if ($hash === false) {
 				continue;
 			}
-			$fileHashes[$file] = sha1($contents);
+			$fileHashes[$file] = $hash;
 		}
 
 		$cacheKey = sprintf('odsl-%s', $directory);

src/Type/Constant/ConstantStringType.php

@@ -135,7 +135,8 @@ function (): string {
 
 	private function export(string $value): string
 	{
-		if (Strings::match($value, '([\000-\037])') !== null) {
+		$escapedValue = addcslashes($value, "\0..\37");
+		if ($escapedValue !== $value) {
 			return '"' . addcslashes($value, "\0..\37\\\"") . '"';
 		}