Skip to content

Commit 06db818

Browse files
committed
feat: update hold piece naming and styling
1 parent 9b8373e commit 06db818

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

src/app/containers/angular-tetris/angular-tetris.component.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,18 @@ $black: #000;
2828

2929
.screen {
3030
width: 390px;
31-
height: 495px;
31+
height: 478px;
3232
border: solid 5px;
3333
border-color: #987f0f #fae36c #fae36c #987f0f;
3434
margin: 0 auto;
3535
position: relative;
3636

3737
.panel {
3838
width: 380px;
39-
height: 485px;
39+
height: 468px;
4040
margin: 0 auto;
4141
background: #9ead86;
42-
padding: 18px 8px;
42+
padding: 8px;
4343
border: 2px solid #494536;
4444
}
4545
}

src/app/interface/tile/tile.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export class Tile {
66
constructor(val: TileValue) {
77
this._value = val;
88
}
9+
910
get isFilled(): boolean {
1011
return this._value === 1;
1112
}

src/app/state/tetris/tetris.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,9 @@ export class TetrisService {
186186
return;
187187
}
188188
this._clearPiece();
189-
const isHoldPieceNone = this._hold.isNone();
190-
const newCurrent = isHoldPieceNone ? this._next : this._hold;
191-
if (isHoldPieceNone) {
189+
const isHoldNonePiece = this._hold.isNone();
190+
const newCurrent = isHoldNonePiece ? this._next : this._hold;
191+
if (isHoldNonePiece) {
192192
this._setNext();
193193
}
194194
this._setHolded(this._current.reset());

src/app/styles/_reset.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ body {
2929
right: 15px;
3030

3131
p {
32-
line-height: 47px;
33-
height: 57px;
32+
line-height: 43px;
33+
height: 50px;
3434
padding: 10px 0 0;
3535
white-space: nowrap;
3636
clear: both;
@@ -39,7 +39,7 @@ body {
3939
.last-row {
4040
position: absolute;
4141
width: 114px;
42-
top: 456px;
42+
top: 430px;
4343
left: 0;
4444
}
4545
}

0 commit comments

Comments
 (0)