Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kopecmi8/PowerBI-JavaScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: microsoft/PowerBI-JavaScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 164 files changed
  • 12 contributors

Commits on Apr 24, 2023

  1. Configuration menu
    Copy the full SHA
    7a11e96 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Merged PR 395869: Minor version bump 2.22.3

    Minor version bump 2.22.3
    This release will contain 1 change:
    Pull Request 383914: [JavaScript SDK]: Add Create export in the JavaScript SDK
    
    We need to release the export of create interface so we can consume it in SDK wrppers
    May Hartov authored and May Hartov committed May 14, 2023
    Configuration menu
    Copy the full SHA
    beb9496 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merged PR 399642: Upgrade wpmp version

    Upgrade wpmp version
    Or Shemesh authored and May Hartov committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2782914 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merged PR 399733: [Version bump] 2.22.4 version bump

    2.22.4 version bump
    This version bump includes the upgrade of WPMP from ^2 to ^2.7
    May Hartov authored and May Hartov committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0e09337 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Configuration menu
    Copy the full SHA
    3e15755 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. This uses [Azure DevOps scheduled triggers](https://learn.microsoft.c…

    …om/en-us/azure/devops/pipelines/process/scheduled-triggers?view=azure-devops&tabs=yaml) to run a weekly build on Saturday at midnight. See [cron syntax](https://learn.microsoft.com/en-us/azure/devops/pipelines/process/scheduled-triggers?view=azure-devops&tabs=yaml#cron-syntax) to adjust the schedule as needed.
    
    This change ensures that this repo meets static analysis requirements as per the [Mandatory SDL Requirement](https://liquid.microsoft.com/Web/Object/Read/ms.security/Requirements/Microsoft.Security.SystemsADM.10201).
    [FAQs] (https://strikecommunity.azurewebsites.net/articles/9931/continuous-sdl-faq-codeql.html), which requires a fresh codeql build every 30 days.
    
    To check whether your repository has been onboarded visit the [Lookup Service] (https://semmleportal.azurewebsites.net/lookup) and enter your repository URL - you should see the main branch of your repo in the list.
    contact [email protected] for further help & details
    
    ---
    
    For feedback or questions about this PR, please find the contact information in the above description. If none exists, please contact the [Gardener team](mailto:[email protected]) to help route.
    
    ---
    
    This change was automatically generated by [1ES Gardener](https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/gardener/1es-gardener) (a [MerlinBot](https://aka.ms/MerlinBot) extension) which is an initiative by the 1ES team to help repos stay up-to-date with latest tools, features, and best practices.
    MerlinBot authored and MerlinBot committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d564c80 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merged PR 446928: Updating models version to 1.13.0

    Updating models version to 1.13.0
    Andres De La Pena Santana authored and Andres De La Pena Santana committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b4d5922 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merged PR 305013: Add smart narrative API to report

    #839888 add getSmartNarrativeInsights to report
    
    Related work items: #839888
    Yoav Damri committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    61e39a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Merged PR 483438: JS SDK - embed URL validation

    Following MSRC case as malicious site can be injected as the embed iframe src, added embed URL validation to ensure the host is an allowed PBI src.
    
    A valid embed url protocol is "https:"
    
    The valid hosts names are ([retrieved from EV2-deployment repository - all of ida_PowerBIFeUrl key values](https://dev.azure.com/powerbi/PowerBIClients/_search?action=contents&text=ida_PowerBIFeUrl path%3A*envParams*&type=code&lp=code-Project&filters=ProjectFilters{PowerBIClients}RepositoryFilters{PowerBIClients-EV2-Deployment}&pageSize=25&result=DefaultCollection/PowerBIClients/PowerBIClients-EV2-Deployment/GBmaster//WFE/AppService/ADM/Public/INT/envParams.txt)):
    
    -  app.powerbi.com,
    -  app.powerbi.cn,
    -   app.powerbigov.us,
    -  app.mil.powerbigov.us,
    -  app.high.powerbigov.us,
    -  app.powerbi.eaglex.ic.gov,
    -  app.powerbi.microsoft.scloud,
    -   powerbi-df.analysis-df.windows.net,
    -   CST WFE URLs: 'https://{cst-name}.analysis.windows-int.net/'
    -   daily.powerbi.com
    -   dxt.powerbi.com
    -   msit.powerbi.com
    
    Embed URL validation should include fabric embed URL.
    
    All of the above should be covered by the following regex expressions:
    
    .+\.powerbi.com$
    -   daily.powerbi.com
    -   dxt.powerbi.com
    -   msit.powerbi.com
    -  app.powerbi.com
    
    FF:  ^app(.mil.|.high.|.)powerbigov.us$
    -   app.powerbigov.us,
    -  app.mil.powerbigov.us,
    -  app.high.powerbigov.us
    
    Edog: .+\.analysis-df.windows.net$
    
    Onebox and CSTs: .+\.analysis.windows-int.net$
    
    Fabric URLs: .+\.fabric.microsoft.com$
    
    **Please look into the test cases in utils.spec.ts to see the valid and invalid embe urls**
    
    Related work items: #1245653
    May Hartov authored and May Hartov committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    d0af4f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merged PR 517660: version bump 2.23.0

    version bump 2.3.0
    May Hartov authored and May Hartov committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    e9423b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Merged PR 521465: Block refresh API for paginated reports

    Client-side APIs are not supported for rdl reports.
    
    Ideally, we should refactor our code to have one validation for all APIs. This requires major changes in the SDK code. So, I added this missing validation per request from customer especially that this API name is not clear that it is Power BI report specifc and might be misleading for customers.
    
    [Incident 474677846 : [PowerBI] CSS - Embedded (User Owns Data/Apps Owns Data): <Programmatic refresh of paginated report in embedded doesn't work>](https://portal.microsofticm.com/imp/v3/incidents/incident/474677846/summary)
    aliabufoul committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    85fe031 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Merged PR 539275: removed global flag from valid embed hosts validation

    removed global flag from valid embed hosts validation to resolve bug introduced with 2.23.0 release:
    
    Issue reported [here](https://community.fabric.microsoft.com/t5/Developer/bd-p/Developer) and by @<Sergey Pustynsky> from datahub (attaching Sergey's description):
    
    We started to get
    "Invalid embed URL detected. Either URL hostname or protocol are invalid. Please use Power BI REST APIs to get the valid URL";
    in Datahub embed scenario. We have 2 tabs, each one renders iframe with different configs. Once it rendered OK, 2nd time fails on error.
    
    It caused by this code, which looks valid
    
    The result of this check is inconsistent (once returns true, once false) over the same data. It's possibly related to RegEx statefullness.
    Do we really need this global flag in RegEx definition?
    
    Symptoms:
    
    `When a RegExp object is created with the global (g) or sticky (y) flag, it maintains an internal lastIndex property. This property is used to determine where to start the next match attempt during subsequent calls to .test() or .exec() methods. After each match attempt, lastIndex is updated. This means if a match is found, the next call to .test() will start searching from the position after the last match, which can lead to the following outcomes:
    If the next call does not find a match (because it starts searching from a non-zero lastIndex), .test() will return false.
    If you call .test() again after it returns false, lastIndex is reset to 0, and the regex is evaluated from the beginning of the string, potentially returning true again if a match is found from the start.`
    
    Related work items: #1362247
    May Hartov authored and May Hartov committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    04a3285 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Merged PR 540280: version bump 2.23.1

    version bump 2.23.1, minor bug fix of embed url validation
    May Hartov authored and May Hartov committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    8110830 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    6b29334 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10d3360 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    d9aeded View commit details
    Browse the repository at this point in the history
  2. Merge pull request microsoft#390 from microsoft/readme_update_support

    Update README.md with support section
    orshemesh16 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b92cba3 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2025

  1. Update package

    ayeshurun committed Jan 28, 2025
    Configuration menu
    Copy the full SHA
    d5ea0da View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2025

  1. Configuration menu
    Copy the full SHA
    61e8ba0 View commit details
    Browse the repository at this point in the history
Loading