glayzzle#386 - improve tests

Author: ichiriac

src/index.js

@@ -84,7 +84,7 @@ const engine = function(options) {
         if (typeof options.parser.version === "string") {
           let version = options.parser.version.split(".");
           version = parseInt(version[0]) * 100 + parseInt(version[1]);
-          if (isNaN(options.parser.version)) {
+          if (isNaN(version)) {
             throw new Error("Bad version number : " + options.parser.version);
           } else {
             options.parser.version = version;
@@ -93,7 +93,7 @@ const engine = function(options) {
           throw new Error("Expecting a number for version");
         }
         if (options.parser.version < 500 || options.parser.version > 704) {
-          throw new Error("Can only handle versions between 5.0 to 7.4");
+          throw new Error("Can only handle versions between 5.x to 7.x");
         }
       }
     }

test/version.test.js

@@ -0,0 +1,54 @@
+const parser = require("./main");
+
+describe("Test versions", function() {
+  it("unserialize a version string", function() {
+    const test = parser.create({
+      parser: {
+        version: "7.3"
+      }
+    });
+    expect(test.parser.version).toEqual(703);
+  });
+  it("unserialize a version string - with bugfix ignored", function() {
+    const test = parser.create({
+      parser: {
+        version: "7.3.5"
+      }
+    });
+    expect(test.parser.version).toEqual(703);
+  });
+  it("fail to parse array", function() {
+    expect(
+      parser.create.bind(null, {
+        parser: {
+          version: [701]
+        }
+      })
+    ).toThrow(new Error("Expecting a number for version"));
+  });
+  it("fail to parse bad version numbers", function() {
+    expect(
+      parser.create.bind(null, {
+        parser: {
+          version: "x.y.z"
+        }
+      })
+    ).toThrow(new Error("Bad version number : x.y.z"));
+  });
+  it("unhandled version", function() {
+    expect(
+      parser.create.bind(null, {
+        parser: {
+          version: "4.9"
+        }
+      })
+    ).toThrow(new Error("Can only handle versions between 5.x to 7.x"));
+    expect(
+      parser.create.bind(null, {
+        parser: {
+          version: "8.9"
+        }
+      })
+    ).toThrow(new Error("Can only handle versions between 5.x to 7.x"));
+  });
+});